Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4A54C103E2 for ; Tue, 27 May 2014 18:55:52 +0000 (UTC) Received: (qmail 93681 invoked by uid 500); 27 May 2014 18:55:51 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 93636 invoked by uid 500); 27 May 2014 18:55:51 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 93625 invoked by uid 99); 27 May 2014 18:55:51 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 May 2014 18:55:51 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id AEAE61D97B5; Tue, 27 May 2014 18:55:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0275818165813935585==" MIME-Version: 1.0 Subject: Re: Review Request 21776: AWSAPI: cloudstack api on POST requests (instead GET), ssl enabling fixed From: "Chiradeep Vittal" To: "daan Hoogland" , "Chiradeep Vittal" Cc: "Dmitry Batkovich" , "cloudstack" Date: Tue, 27 May 2014 18:55:43 -0000 Message-ID: <20140527185543.12585.30532@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Chiradeep Vittal" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/21776/ X-Sender: "Chiradeep Vittal" References: <20140526143233.12584.92698@reviews.apache.org> In-Reply-To: <20140526143233.12584.92698@reviews.apache.org> Reply-To: "Chiradeep Vittal" X-ReviewRequest-Repository: cloudstack-git --===============0275818165813935585== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21776/#review44020 ----------------------------------------------------------- In EC2engine.java, I still see code blocks such as if (foo) \n blargh() reformatted to if (foo) blargh Please add prachidamle as a reviewer - Chiradeep Vittal On May 26, 2014, 2:32 p.m., Dmitry Batkovich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21776/ > ----------------------------------------------------------- > > (Updated May 26, 2014, 2:32 p.m.) > > > Review request for cloudstack, Chiradeep Vittal and daan Hoogland. > > > Repository: cloudstack-git > > > Description > ------- > > * CloudStackClient.java http request mechanism replaced from GET requests to POST for supporting EC2 requests larger than 2KB > * SSL enabling fixed in EC2Engine.java > > continuation of https://reviews.apache.org/r/17586/ > > > Diffs > ----- > > awsapi/conf/ec2-service.properties.in 82f5ad8 > awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java cd20214 > awsapi/src/com/cloud/bridge/util/JsonAccessor.java 2a94dea > awsapi/src/com/cloud/bridge/util/JsonElementUtil.java PRE-CREATION > awsapi/src/com/cloud/bridge/util/JsonElementUtil.java 2d8afb5 > awsapi/src/com/cloud/stack/CloudStackApi.java b7a1210 > awsapi/src/com/cloud/stack/CloudStackClient.java 03eba96 > awsapi/src/com/cloud/stack/CloudStackClientException.java PRE-CREATION > awsapi/src/com/cloud/stack/CloudStackClientException.java ac1b3ef > awsapi/src/com/cloud/stack/CloudStackCommand.java 8d6aa68 > awsapi/src/com/cloud/stack/CloudStackQueryBuilder.java PRE-CREATION > awsapi/test/com/cloud/gate/util/CloudStackClientTestCase.java 826cb3a > awsapi/test/com/cloud/gate/util/JsonAccessorTestCase.java 8603e59 > awsapi/test/com/cloud/gate/util/JsonElementUtilTestCase.java PRE-CREATION > awsapi/test/com/cloud/gate/util/JsonElementUtilTestCase.java 8b4f267 > > Diff: https://reviews.apache.org/r/21776/diff/ > > > Testing > ------- > > > Thanks, > > Dmitry Batkovich > > --===============0275818165813935585==--