Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B55F21079A for ; Tue, 27 May 2014 08:03:15 +0000 (UTC) Received: (qmail 5699 invoked by uid 500); 27 May 2014 08:03:15 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 5657 invoked by uid 500); 27 May 2014 08:03:15 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 5647 invoked by uid 99); 27 May 2014 08:03:15 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 May 2014 08:03:15 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1B5741D971C; Tue, 27 May 2014 08:03:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2731440469306924419==" MIME-Version: 1.0 Subject: Review Request 21923: CLOUDSTACK-5342: Fix for failure in adding network to VM From: "Gaurav Aradhye" To: "Santhosh Edukulla" Cc: "Gaurav Aradhye" , "cloudstack" Date: Tue, 27 May 2014 08:03:07 -0000 Message-ID: <20140527080307.12585.3889@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Gaurav Aradhye" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/21923/ X-Sender: "Gaurav Aradhye" Reply-To: "Gaurav Aradhye" X-ReviewRequest-Repository: cloudstack-git --===============2731440469306924419== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21923/ ----------------------------------------------------------- Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-5342 https://issues.apache.org/jira/browse/CLOUDSTACK-5342 Repository: cloudstack-git Description ------- Few test cases are failing while adding NIC to VM, because if add nic operation is done immediately after remove nic operation on the same VM, it fails. This is identified as qemu issue. But we can handle it through test case by avoiding this by spawning new VM wherever required. Adding delay doesn't help. Please go through discussion (https://issues.apache.org/jira/browse/CLOUDSTACK-5342) for more info. Diffs ----- test/integration/component/test_add_remove_network.py c17293d tools/marvin/marvin/lib/base.py c975c37 Diff: https://reviews.apache.org/r/21923/diff/ Testing ------- Yes. Log: Add network to running VM ... SKIP: skip Add network to stopped VM ... === TestName: test_02_add_nw_stopped_vm_1_isolated | Status : SUCCESS === ok Add network to stopped VM ... === TestName: test_02_add_nw_stopped_vm_2_shared | Status : SUCCESS === ok Add same network multiple times to running VM ... === TestName: test_03_add_nw_multiple_times_1_isolated | Status : SUCCESS === ok Add same network multiple times to running VM ... === TestName: test_03_add_nw_multiple_times_2_shared | Status : SUCCESS === ok Add VPC network to running VM belonging to isolated network ... === TestName: test_04_vpc_nw_running_vm_1_isolated | Status : SUCCESS === ok Add network and ip address to running VM ... === TestName: test_06_add_nw_ipaddress_running_vm | Status : SUCCESS === ok ---------------------------------------------------------------------- Ran 7 tests in 902.523s OK (SKIP=1) Thanks, Gaurav Aradhye --===============2731440469306924419==--