Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0D37ACBE8 for ; Mon, 26 May 2014 05:14:39 +0000 (UTC) Received: (qmail 33514 invoked by uid 500); 26 May 2014 05:14:38 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 33468 invoked by uid 500); 26 May 2014 05:14:38 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 33454 invoked by uid 99); 26 May 2014 05:14:38 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 May 2014 05:14:38 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B14F41D9740; Mon, 26 May 2014 05:14:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1642774445669662381==" MIME-Version: 1.0 Subject: Re: Review Request 20621: CLOUDSTACK-6529: Fixed adding hosts even if any host addition fails. From: "ASF Subversion and Git Services" To: "Abhinandan Prateek" Cc: "Santhosh Edukulla" , "ASF Subversion and Git Services" , "cloudstack" Date: Mon, 26 May 2014 05:14:30 -0000 Message-ID: <20140526051430.12586.63702@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "ASF Subversion and Git Services" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/20621/ X-Sender: "ASF Subversion and Git Services" References: <20140523123955.29379.86438@reviews.apache.org> In-Reply-To: <20140523123955.29379.86438@reviews.apache.org> Reply-To: "ASF Subversion and Git Services" X-ReviewRequest-Repository: cloudstack-git --===============1642774445669662381== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20621/#review43912 ----------------------------------------------------------- Commit 6f3ff068270f48e00531c462de4f7d76395658ff in cloudstack's branch refs/heads/4.4-forward from santhosh [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6f3ff06 ] Added fix for CLOUDSTACK-6529 Fixed to continue adding all hosts, even if any addition fails and remove unused args from host class. Signed-off-by: santhosh Signed-off-by: Abhinandan Prateek - ASF Subversion and Git Services On May 23, 2014, 12:39 p.m., Santhosh Edukulla wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20621/ > ----------------------------------------------------------- > > (Updated May 23, 2014, 12:39 p.m.) > > > Review request for cloudstack and Abhinandan Prateek. > > > Bugs: CLOUDSTACK-6529 > https://issues.apache.org/jira/browse/CLOUDSTACK-6529 > > > Repository: cloudstack-git > > > Description > ------- > > 1. In deployDataCenter when a host addition fails, it is not continuing further. Added a change, to continue adding all hosts, even if any addition fails. Do a cleanup only when all host addition fails. Tested the changes on local setup > > 2. Removed another unwanted arguments from class host which are not part of addHost call. > 3. Added an exit check based upon correct input file path type. > > > Diffs > ----- > > tools/marvin/marvin/configGenerator.py 66609da > tools/marvin/marvin/deployDataCenter.py 4d8be58 > > Diff: https://reviews.apache.org/r/20621/diff/ > > > Testing > ------- > > Tested the changes that it is not breaking existing deployDataCenter. > > > Thanks, > > Santhosh Edukulla > > --===============1642774445669662381==--