Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============3467871524142006352=="
MIME-Version: 1.0
Subject: Re: Review Request 21554: CLOUDSTACK-6657: Adding condition for
 checking
 error code 530 across test cases
From: "SrikanteswaraRao Talluri" <srikanteswararao.talluri@citrix.com>
To: "Santhosh Edukulla" <santhosh.edukulla@citrix.com>
Cc: "Gaurav Aradhye" <gaurav.aradhye@clogeny.com>,
 "SrikanteswaraRao Talluri" <srikanteswararao.talluri@citrix.com>,
 "cloudstack" <dev@cloudstack.apache.org>
Date: Fri, 16 May 2014 13:25:20 -0000
Message-ID: <20140516132520.16800.67371@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "SrikanteswaraRao Talluri" <noreply@reviews.apache.org>
References: <20140516123641.715.22073@reviews.apache.org>
In-Reply-To: <20140516123641.715.22073@reviews.apache.org>
Reply-To: "SrikanteswaraRao Talluri" <srikanteswararao.talluri@citrix.com>

--===============3467871524142006352==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21554/#review43206
-----------------------------------------------------------

Ship it!


Ship It!

- SrikanteswaraRao Talluri


On May 16, 2014, 12:36 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21554/
> -----------------------------------------------------------
> 
> (Updated May 16, 2014, 12:36 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6657
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6657
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Adding explicit check for error code 530 in the response received form the server wherever applicable.
> I have made these changes in all those files which failed due to having wrong assert (Build #348 KVM regression).
> 
> Will add more of these changes in other files whenever found failing due to above reason in the build logs.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_accounts.py cf5f2b6 
>   test/integration/component/test_add_remove_network.py c17293d 
>   test/integration/component/test_affinity_groups.py d0fa2f7 
>   test/integration/component/test_assign_vm.py 24b63a6 
>   test/integration/component/test_ip_reservation.py c84f63c 
>   test/integration/component/test_non_contiguous_vlan.py 4609af9 
>   test/integration/component/test_projects.py c593fb6 
>   test/integration/component/test_volumes.py b5b08e2 
>   test/integration/component/test_vpc.py e9d396e8 
>   test/integration/component/test_vpc_network.py a449948 
>   test/integration/component/test_vpc_network_lbrules.py a5625e7 
>   test/integration/component/test_vpc_vms_deployment.py 1c1f93d 
>   test/integration/smoke/test_network.py 6beb071 
>   test/integration/smoke/test_nic.py 592a839 
>   test/integration/smoke/test_primary_storage.py 3147d86 
>   test/integration/smoke/test_volumes.py 5908e2b 
> 
> Diff: https://reviews.apache.org/r/21554/diff/
> 
> 
> Testing
> -------
> 
> Tested all test suites with python command.
> Tested only few test suites by running them, not all. Same working change has been applied to all files.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


--===============3467871524142006352==--