Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 20FC7117A1 for ; Sun, 4 May 2014 21:12:41 +0000 (UTC) Received: (qmail 55524 invoked by uid 500); 4 May 2014 21:12:40 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 55447 invoked by uid 500); 4 May 2014 21:12:40 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 55437 invoked by uid 99); 4 May 2014 21:12:39 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 04 May 2014 21:12:39 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 884B31D74ED; Sun, 4 May 2014 21:12:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3619191603384219587==" MIME-Version: 1.0 Subject: Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes) From: "Alex Ough" To: "Alex Ough" , "Alena Prokharchyk" , "cloudstack" Date: Sun, 04 May 2014 21:12:32 -0000 Message-ID: <20140504211232.29336.68042@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Alex Ough" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/20099/ X-Sender: "Alex Ough" References: <20140416190626.12706.44532@reviews.apache.org> In-Reply-To: <20140416190626.12706.44532@reviews.apache.org> Reply-To: "Alex Ough" X-ReviewRequest-Repository: cloudstack-git --===============3619191603384219587== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20099/ ----------------------------------------------------------- (Updated May 4, 2014, 9:12 p.m.) Review request for cloudstack. Changes ------- core changes Repository: cloudstack-git Description ------- This is the review request for the core changes related with #17790 that has only the new plugin codes. Diffs (updated) ----- api/src/com/cloud/event/EventTypes.java 39ef710 api/src/com/cloud/user/AccountService.java 7e37b38 api/src/org/apache/cloudstack/api/ApiConstants.java fdb4558 api/src/org/apache/cloudstack/api/BaseCmd.java f6f21ae api/src/org/apache/cloudstack/api/ResponseGenerator.java 10fb6df api/src/org/apache/cloudstack/api/command/admin/region/AddRegionCmd.java f6743ba api/src/org/apache/cloudstack/api/command/admin/region/UpdateRegionCmd.java b08cbbb api/src/org/apache/cloudstack/api/response/RegionResponse.java 6c74fa6 api/src/org/apache/cloudstack/query/QueryService.java 01af631 api/src/org/apache/cloudstack/region/Region.java df64e44 api/src/org/apache/cloudstack/region/RegionService.java afefcc7 api/test/org/apache/cloudstack/api/command/test/RegionCmdTest.java 10c3d85 client/pom.xml d8dbde7 client/tomcatconf/commands.properties.in 45debe4 engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml 489b37d engine/schema/src/org/apache/cloudstack/region/RegionVO.java 608bd2b plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java 957f708 plugins/pom.xml 9b391b8 server/resources/META-INF/cloudstack/core/spring-server-core-managers-context.xml fc1c7e2 server/src/com/cloud/api/ApiDBUtils.java 67e47f7 server/src/com/cloud/api/ApiResponseHelper.java 38f2f0b server/src/com/cloud/api/dispatch/ParamProcessWorker.java e9bdd8b server/src/com/cloud/api/query/QueryManagerImpl.java 3abb944 server/src/com/cloud/api/query/ViewResponseHelper.java d06e1d1 server/src/com/cloud/event/ActionEventUtils.java 28e5680 server/src/com/cloud/server/ManagementServerImpl.java bce2930 server/src/com/cloud/user/AccountManager.java 03bf842 server/src/com/cloud/user/AccountManagerImpl.java 2070ee6 server/src/com/cloud/user/DomainManager.java f72b18a server/src/com/cloud/user/DomainManagerImpl.java fbbe0c2 server/src/org/apache/cloudstack/region/RegionManager.java 6f25481 server/src/org/apache/cloudstack/region/RegionManagerImpl.java 8910714 server/src/org/apache/cloudstack/region/RegionServiceImpl.java 98cf500 server/test/com/cloud/api/dispatch/ParamProcessWorkerTest.java 12051a6 server/test/com/cloud/user/MockAccountManagerImpl.java f373cba server/test/com/cloud/user/MockDomainManagerImpl.java 7dddefb server/test/org/apache/cloudstack/region/RegionManagerTest.java d7bc537 setup/db/db/schema-440to450.sql 2bd5386 ui/scripts/regions.js 66dae8c Diff: https://reviews.apache.org/r/20099/diff/ Testing ------- 1. Successfully tested real time synchronization as soon as resources are created/deleted/modified in one region. 2. Successfully tested full scans to synchronize resources that were missed during real time synchronization because of any reasons like network connection issues. 3. The tests were done manually and also automatically by randomly generating changes each region. Thanks, Alex Ough --===============3619191603384219587==--