Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4D50A11ADE for ; Fri, 2 May 2014 20:27:39 +0000 (UTC) Received: (qmail 84185 invoked by uid 500); 2 May 2014 20:27:38 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 84143 invoked by uid 500); 2 May 2014 20:27:38 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 84133 invoked by uid 99); 2 May 2014 20:27:38 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 May 2014 20:27:38 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id F16B31D747F; Fri, 2 May 2014 20:27:31 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2013866714866279852==" MIME-Version: 1.0 Subject: Re: Review Request 21015: CLOUDSTACK-6472 listUsageRecords: Pull information from removed items as well, fixing NPEs/Null UUIDs with usage API calls. From: "ASF Subversion and Git Services" To: "Sam Schmit" , "ASF Subversion and Git Services" , "cloudstack" Date: Fri, 02 May 2014 20:27:31 -0000 Message-ID: <20140502202731.17845.41662@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "ASF Subversion and Git Services" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/21015/ X-Sender: "ASF Subversion and Git Services" References: <20140502181520.17845.32551@reviews.apache.org> In-Reply-To: <20140502181520.17845.32551@reviews.apache.org> Reply-To: "ASF Subversion and Git Services" X-ReviewRequest-Repository: cloudstack-git --===============2013866714866279852== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21015/#review42051 ----------------------------------------------------------- Commit 81b4731e3b5265943017f88b850421154184f7c5 in cloudstack's branch refs/heads/master from Sam Schmit [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=81b4731 ] CLOUDSTACK-6472 listUsageRecords: Pull information from removed items as well, fixing NPEs/Null UUIDs with usage API calls. Signed-off-by: Sebastien Goasguen - ASF Subversion and Git Services On May 2, 2014, 6:15 p.m., Sam Schmit wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21015/ > ----------------------------------------------------------- > > (Updated May 2, 2014, 6:15 p.m.) > > > Review request for cloudstack. > > > Bugs: CLOUDSTACK-6472 > https://issues.apache.org/jira/browse/CLOUDSTACK-6472 > > > Repository: cloudstack-git > > > Description > ------- > > Running "listUsageRecords" when there were any destroyed/expunged Virtual Machines would return errors (on 4.3) or return null UUIDs (on master). The UUID is important for correlating records. > > > Diffs > ----- > > server/src/com/cloud/api/ApiResponseHelper.java 250f5a9 > > Diff: https://reviews.apache.org/r/21015/diff/ > > > Testing > ------- > > 1) Created virtual machine > 2) Ran usage > 3) ran "listUsageRecords" API call, successful data returned > 4) Expunged VM > 5) Ran usage > 6) ran "listUsageRecords" API call, successful data returned (this would previously return an error) > > > Thanks, > > Sam Schmit > > --===============2013866714866279852==--