cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sachchidanand Vaidya <vaidy...@juniper.net>
Subject Re: Review Request 19270: Added service-instance delete command to Juniper Contrail Plugin and related fixes
Date Tue, 20 May 2014 16:51:53 GMT
Hi Rajesh,
    Can you pls review the updated diff.

Thanks,
Sachin

On 5/7/14 3:44 PM, "Sachchidanand Vaidya" <vaidyasd@juniper.net> wrote:

>
>-----------------------------------------------------------
>This is an automatically generated e-mail. To reply, visit:
>https://reviews.apache.org/r/19270/
>-----------------------------------------------------------
>
>(Updated May 7, 2014, 3:44 p.m.)
>
>
>Review request for cloudstack and Rajesh Battala.
>
>
>Changes
>-------
>
>Fixed licenser header and created new EventTypes for serviceInstance VM
>create and delete.
>
>Thanks,
>Sachin
>
>
>Repository: cloudstack-git
>
>
>Description
>-------
>
>This patch has following changes:
> - Added service-instance delete command to Juniper Contrail Plugin.
> - Fixes to plugin code to handle instance-delete operation properly.
> - Fix related to service-instance persistence and re-creation during
>Mgmt server reboot.
>
>
>Diffs (updated)
>-----
>
>  api/src/com/cloud/event/EventTypes.java 075b1c8
>  client/tomcatconf/commands.properties.in d3a24f6
>  
>plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/networ
>k/contrail/api/command/CreateServiceInstanceCmd.java 59c4e61
>  
>plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/networ
>k/contrail/api/command/DeleteServiceInstanceCmd.java PRE-CREATION
>  
>plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/networ
>k/contrail/management/ContrailElementImpl.java 05723b0
>  
>plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/networ
>k/contrail/management/ContrailGuru.java f81c0d0
>  
>plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/networ
>k/contrail/management/ServerDBSyncImpl.java b9a3ed3
>  
>plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/networ
>k/contrail/management/ServiceManager.java e4ef26d
>  
>plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/networ
>k/contrail/management/ServiceManagerImpl.java f34eacc
>  
>plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/networ
>k/contrail/model/ServiceInstanceModel.java e79053c
>
>Diff: https://reviews.apache.org/r/19270/diff/
>
>
>Testing
>-------
>
>Unit tests passed and additional testing done locally.
>
>
>Thanks,
>
>Sachchidanand Vaidya
>


Mime
View raw message