cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nitin Mehta <Nitin.Me...@citrix.com>
Subject Re: seeing "Unknown parameters : ctxdetails" for addResourceDetail/removeResourceDetail
Date Wed, 14 May 2014 01:05:09 GMT
Daan - MS logs are visible only to the admin and not a general user. So
are you saying this is for admin to debug in case he misspelled a param ?

I feel that this shouldn’t be ON by default and whether such logic should
be part of CS core ?
I also find it difficult to understand that in production the admin would
commit such basic mistakes. I am assuming that he/she would be a power
user and would be using well known clients - say cmd line or UI to fire
apis against CS.

Thanks,
-Nitin

On 13/05/14 1:58 PM, "Daan Hoogland" <daan.hoogland@gmail.com> wrote:

>It is usefull for users that misspell a parameter and expect behavior
>related to it. not just in development.
>
>On Tue, May 13, 2014 at 7:24 PM, Nitin Mehta <Nitin.Mehta@citrix.com>
>wrote:
>> I introduced the parameter ctxdetails which carries all the context
>> details (currently all the first class entities and their corresponding
>> interface mapping).
>> This would be done for each of the api and hence seen for all apis.
>>
>> I saw the code in ParamGenericValidationWorker and will fix this. Filed
>>a
>> bug CLOUDSTACK-6658
>> But I am curious why we have this code at all ? It checks whether the
>> params passed for the api are an exact match (nothing more nothing less)
>> to the params we expect and if not throws only a warning as seen below.
>> While it might be good for a developer setup it decreases the
>>performance
>> for production systems I believe.
>>
>> Thanks,
>> -Nitin
>>
>> On 13/05/14 3:01 AM, "Koushik Das" <koushik.das@citrix.com> wrote:
>>
>>>I am seeing the same for many commands. So this is not specific to
>>>add/removeResourceDetail
>>>
>>>2014-05-09 18:17:39,477 WARN  [c.c.a.d.ParamGenericValidationWorker]
>>>(API-Job-Executor-24:job-28 ctx-6eaab5d7) Received unknown parameters
>>>for
>>>command updateNetworkServiceProvider. Unknown parameters : ctxdetails
>>>2014-05-09 18:17:42,584 WARN  [c.c.a.d.ParamGenericValidationWorker]
>>>(API-Job-Executor-25:job-29 ctx-9c9f87f4) Received unknown parameters
>>>for
>>>command updatePhysicalNetwork. Unknown parameters : ctxdetails
>>>2014-05-12 11:13:29,079 WARN  [c.c.a.d.ParamGenericValidationWorker]
>>>(API-Job-Executor-1:job-3 ctx-146e0b74) Received unknown parameters for
>>>command createPhysicalNetwork. Unknown parameters : ctxdetails
>>>2014-05-12 11:13:29,188 WARN  [c.c.a.d.ParamGenericValidationWorker]
>>>(API-Job-Executor-2:job-4 ctx-923175d9) Received unknown parameters for
>>>command addTrafficType. Unknown parameters : ctxdetails
>>>2014-05-12 11:13:44,521 WARN  [c.c.a.d.ParamGenericValidationWorker]
>>>(API-Job-Executor-5:job-7 ctx-255c7f04) Received unknown parameters for
>>>command configureVirtualRouterElement. Unknown parameters : ctxdetails
>>>2014-05-12 11:13:44,576 WARN  [c.c.a.d.ParamGenericValidationWorker]
>>>(API-Job-Executor-6:job-8 ctx-5bbd3334) Received unknown parameters for
>>>command updateNetworkServiceProvider. Unknown parameters : ctxdetails
>>>2014-05-12 11:13:49,705 WARN  [c.c.a.d.ParamGenericValidationWorker]
>>>(API-Job-Executor-7:job-9 ctx-382414ba) Received unknown parameters for
>>>command configureVirtualRouterElement. Unknown parameters : ctxdetails
>>>2014-05-12 11:13:49,746 WARN  [c.c.a.d.ParamGenericValidationWorker]
>>>(API-Job-Executor-8:job-10 ctx-e806b020) Received unknown parameters for
>>>command updateNetworkServiceProvider. Unknown parameters : ctxdetails
>>>2014-05-12 11:13:54,873 WARN  [c.c.a.d.ParamGenericValidationWorker]
>>>(API-Job-Executor-9:job-11 ctx-6f762490) Received unknown parameters for
>>>command configureInternalLoadBalancerElement. Unknown parameters :
>>>ctxdetails
>>>2014-05-12 11:13:54,917 WARN  [c.c.a.d.ParamGenericValidationWorker]
>>>(API-Job-Executor-10:job-12 ctx-a9a7f4dd) Received unknown parameters
>>>for
>>>command updateNetworkServiceProvider. Unknown parameters : ctxdetails
>>>2014-05-12 11:14:00,003 WARN  [c.c.a.d.ParamGenericValidationWorker]
>>>(API-Job-Executor-11:job-13 ctx-434a524d) Received unknown parameters
>>>for
>>>command updatePhysicalNetwork. Unknown parameters : ctxdetails
>>>2014-05-12 17:50:42,708 WARN  [c.c.a.d.ParamGenericValidationWorker]
>>>(API-Job-Executor-1:job-21 ctx-706223d8) Received unknown parameters for
>>>command deployVirtualMachine. Unknown parameters : ctxdetails
>>>2014-05-13 14:19:43,496 WARN  [c.c.a.d.ParamGenericValidationWorker]
>>>(API-Job-Executor-4:job-31 ctx-aff14d23) Received unknown parameters for
>>>command deployVirtualMachine. Unknown parameters : ctxdetails
>>>2014-05-13 14:48:59,308 WARN  [c.c.a.d.ParamGenericValidationWorker]
>>>(API-Job-Executor-1:job-53 ctx-9cc47c4f) Received unknown parameters for
>>>command startVirtualMachine. Unknown parameters : ctxdetails
>>>2014-05-13 14:50:18,255 WARN  [c.c.a.d.ParamGenericValidationWorker]
>>>(API-Job-Executor-5:job-61 ctx-5ceecd58) Received unknown parameters for
>>>command startVirtualMachine. Unknown parameters : ctxdetails
>>>
>>>
>>>
>>>
>>>
>>>On 13-May-2014, at 4:09 AM, Alena Prokharchyk
>>><Alena.Prokharchyk@citrix.com> wrote:
>>>
>>>> Hi Antonio,
>>>>
>>>> I see following errors in the 4.4 logs:
>>>>
>>>> WARN  [c.c.a.d.ParamGenericValidationWorker]
>>>>(API-Job-Executor-49:job-2867 ctx-072e9ae9) Received unknown parameters
>>>>for command removeResourceDetail. Unknown parameters : ctxdetails
>>>> WARN  [c.c.a.d.ParamGenericValidationWorker]
>>>>(API-Job-Executor-50:job-2868 ctx-35195840) Received unknown parameters
>>>>for command addResourceDetail. Unknown parameters : ctxdetails
>>>>
>>>> Isn¹t something that you¹ve fixed already? If so, what branches did it
>>>>go to? If not, can you please fix it?
>>>>
>>>> Thanks!
>>>> Alena.
>>>
>>
>
>
>
>-- 
>Daan


Mime
View raw message