cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mike Tutkowski <mike.tutkow...@solidfire.com>
Subject Re: How is this working?
Date Tue, 06 May 2014 07:25:27 GMT
Could you please update this ticket with the dashboard part?

https://issues.apache.org/jira/browse/CLOUDSTACK-6579

Thanks!


On Mon, May 5, 2014 at 9:55 PM, Koushik Das <koushik.das@citrix.com> wrote:

> The dashboard in CS UI is impacted by this.
>
> On 05-May-2014, at 11:25 PM, Mike Tutkowski <mike.tutkowski@solidfire.com>
> wrote:
>
> > OK, I can log a JIRA ticket for this.
> >
> > Thanks
> >
> >
> > On Mon, May 5, 2014 at 11:49 AM, Nitin Mehta <Nitin.Mehta@citrix.com>
> wrote:
> >
> >> Ideally, we should deprecate the column since its not used and causes
> >> confusion.
> >> Setting to this value wouldn't help because this column is never updated
> >> regularly.
> >>
> >> On 05/05/14 10:28 AM, "Mike Tutkowski" <mike.tutkowski@solidfire.com>
> >> wrote:
> >>
> >>> How's about I just check this code into master?
> >>>
> >>> poolVO.setUsedBytes(mspAnswer.getPoolInfo().getCapacityBytes() -
> >>> mspAnswer.getPoolInfo().getAvailableBytes());
> >>>
> >>> It is patterned off of the PrimaryDataStoreHelper.attachHost logic,
> which
> >>> looks like this:
> >>>
> >>> pool.setUsedBytes(existingInfo.getCapacityBytes() -
> >>> existingInfo.getAvailableBytes());
> >>>
> >>>
> >>> On Mon, May 5, 2014 at 10:21 AM, Nitin Mehta <Nitin.Mehta@citrix.com>
> >>> wrote:
> >>>
> >>>> This column is not used for calculating capacity for pool.
> >>>> We have always used op host capacity table. Nevertheless please do
> file
> >>>> a
> >>>> bug
> >>>>
> >>>> Thanks,
> >>>> -Nitin
> >>>> ________________________________________
> >>>> From: Mike Tutkowski [mike.tutkowski@solidfire.com]
> >>>> Sent: Monday, May 05, 2014 9:12 PM
> >>>> To: dev@cloudstack.apache.org
> >>>> Subject: Re: How is this working?
> >>>>
> >>>> My storage plug-in actually uses a custom host listener, so I have not
> >>>> encountered this issue.
> >>>>
> >>>> I don't remember off hand if it was in 4.2 or 4.3, but at some point
> >>>> someone changed the storage_pool table's available_bytes column to be
> >>>> used_bytes.
> >>>>
> >>>> It looks like this code you reference was missed.
> >>>>
> >>>>
> >>>> On Mon, May 5, 2014 at 4:35 AM, Koushik Das <koushik.das@citrix.com>
> >>>> wrote:
> >>>>
> >>>>> I came across this code snippet in hostConnect() method in
> >>>>> DefaultHostListener.java. Look at the line where the used bytes
is
> >>>> set on
> >>>>> the poolVO. This looks like a serious bug. Looking at the history
> this
> >>>> code
> >>>>> has been there since a year. Has anyone encountered any issues with
> >>>> primary
> >>>>> storage capacity?
> >>>>>
> >>>>> ModifyStoragePoolAnswer mspAnswer = (ModifyStoragePoolAnswer)answer;
> >>>>> Š..
> >>>>> StoragePoolVO poolVO = this.primaryStoreDao.findById(poolId);
> >>>>> poolVO.setUsedBytes(mspAnswer.getPoolInfo().getAvailableBytes());
> >>>>> poolVO.setCapacityBytes(mspAnswer.getPoolInfo().getCapacityBytes());
> >>>>> primaryStoreDao.update(pool.getId(), poolVO);
> >>>>>
> >>>>>
> >>>>> -Koushik
> >>>>>
> >>>>
> >>>>
> >>>>
> >>>> --
> >>>> *Mike Tutkowski*
> >>>> *Senior CloudStack Developer, SolidFire Inc.*
> >>>> e: mike.tutkowski@solidfire.com
> >>>> o: 303.746.7302
> >>>> Advancing the way the world uses the
> >>>> cloud<http://solidfire.com/solution/overview/?video=play>
> >>>> * *
> >>>>
> >>>
> >>>
> >>>
> >>> --
> >>> *Mike Tutkowski*
> >>> *Senior CloudStack Developer, SolidFire Inc.*
> >>> e: mike.tutkowski@solidfire.com
> >>> o: 303.746.7302
> >>> Advancing the way the world uses the
> >>> cloud<http://solidfire.com/solution/overview/?video=play>
> >>> * *
> >>
> >>
> >
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkowski@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the
> > cloud<http://solidfire.com/solution/overview/?video=play>
> > *™*
>
>


-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkowski@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud<http://solidfire.com/solution/overview/?video=play>
*™*

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message