cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Santhosh Edukulla" <santhosh.eduku...@citrix.com>
Subject Re: Review Request 21973: CLOUDSTACK-6780: Resolved cleanup issue in portable ip test cases
Date Wed, 28 May 2014 07:09:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21973/#review44103
-----------------------------------------------------------



test/integration/component/test_portable_ip.py
<https://reviews.apache.org/r/21973/#comment78429>

    Here, we are deleting with api_client_user, but in finally self.apiclient. Is that the
purpose?



test/integration/component/test_portable_ip.py
<https://reviews.apache.org/r/21973/#comment78430>

    same entity is getting deleting both in try\finally. This case can happen when there is
no exception thrown from CS and it will hit try and then finally. It will lead to exception
again. 


- Santhosh Edukulla


On May 28, 2014, 7:04 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21973/
> -----------------------------------------------------------
> 
> (Updated May 28, 2014, 7:04 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-6780
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6780
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Portable IP address was not getting disassociated. Added it to finally block so that
it will get associated always and portable ip range gets cleaned up properly during cleanup.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_portable_ip.py 847bb4a 
> 
> Diff: https://reviews.apache.org/r/21973/diff/
> 
> 
> Testing
> -------
> 
> Test disassociating portable ip ... === TestName: test_disassociate_ip_address_no_services
| Status : SUCCESS ===
> ok
> Test disassociating portable IP with non-owner account ... === TestName: test_disassociate_ip_address_other_account
| Status : SUCCESS ===
> ok
> Test disassociating portable ip ... === TestName: test_disassociate_ip_address_services_enabled
| Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 3 tests in 263.215s
> 
> OK
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message