cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Santhosh Edukulla" <santhosh.eduku...@citrix.com>
Subject Re: Review Request 21926: CLOUDSTACK-6782: Egress FW rules test cases - Format unicode to string before string matching
Date Tue, 27 May 2014 18:19:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21926/#review44008
-----------------------------------------------------------

Ship it!


Ship It!

- Santhosh Edukulla


On May 27, 2014, 1:14 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21926/
> -----------------------------------------------------------
> 
> (Updated May 27, 2014, 1:14 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6782
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6782
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Test cases are failing because unicode data does not match with string.
> E.g. Script result is [u'100'] is not matching with ['100']
> 
> Current code converts it to string but when the result is a list, then we have to convert
each item to string. Formatting list to string does not help.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_egress_fw_rules.py a42caa9 
> 
> Diff: https://reviews.apache.org/r/21926/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> Log:
> Test By-default the communication from guest n/w to public n/w is NOT allowed. ... ===
TestName: test_01_1_egress_fr1 | Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 1 test in 523.654s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message