cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abhinandan Prateek" <aprat...@apache.org>
Subject Re: Review Request 20621: CLOUDSTACK-6529: Fixed adding hosts even if any host addition fails.
Date Mon, 26 May 2014 05:14:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20621/#review43911
-----------------------------------------------------------

Ship it!


Ship It!

- Abhinandan Prateek


On May 23, 2014, 12:39 p.m., Santhosh Edukulla wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20621/
> -----------------------------------------------------------
> 
> (Updated May 23, 2014, 12:39 p.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: CLOUDSTACK-6529
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6529
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> 1. In deployDataCenter when a host addition fails, it is not continuing further. Added
a change, to continue adding all hosts, even if any addition fails. Do a cleanup only when
all host addition fails. Tested the changes on local setup 
> 
> 2. Removed another unwanted arguments from class host which are not part of addHost call.
> 3. Added an exit check based upon correct input file path type.
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/configGenerator.py 66609da 
>   tools/marvin/marvin/deployDataCenter.py 4d8be58 
> 
> Diff: https://reviews.apache.org/r/20621/diff/
> 
> 
> Testing
> -------
> 
> Tested the changes that it is not breaking existing deployDataCenter.
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message