cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Nielsen" <j...@betterservers.com>
Subject Re: Review Request 21431: CLOUDSTACK-6665: A fix for vpc routers not releasing dhcp leases.
Date Fri, 16 May 2014 20:49:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21431/#review43260
-----------------------------------------------------------


I was just about to post something similar, thanks for reporting. Below I propose a slightly
more reliable way to extract the interface name from the "ip route" output:

$(ip route get 10.0.0.117 | grep " dev " | sed -e "s/^.* dev \([^ ]*\) .*$/\1/g")

- John Nielsen


On May 14, 2014, 1:58 p.m., Joris van Lieshout wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21431/
> -----------------------------------------------------------
> 
> (Updated May 14, 2014, 1:58 p.m.)
> 
> 
> Review request for cloudstack, daan Hoogland, Hugo Trippaers, and Sheng Yang.
> 
> 
> Bugs: cloudstack-6665
>     https://issues.apache.org/jira/browse/cloudstack-6665
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The releasing of dhcp leases on vpc routers fails because the network on which the instance
that holds the lease lives is not behind eth0, like with normal router vms. The current code
assumes eth0, this patch will make interface selection dynamic based on the ipv4 address of
the instance.
> 
> 
> Diffs
> -----
> 
>   systemvm/patches/debian/config/opt/cloud/bin/edithosts.sh 70c95a8 
> 
> Diff: https://reviews.apache.org/r/21431/diff/
> 
> 
> Testing
> -------
> 
> Tested on vpc routers in our own environment. Manual workaround for vpc experiencing
this issue was to execute the command in this patch by hand.
> 
> 
> Thanks,
> 
> Joris van Lieshout
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message