cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF Subversion and Git Services" <asf...@urd.zones.apache.org>
Subject Re: Review Request 20659: CLOUDSTACK-5674: Fixed cloudstackConnection.py to return FAILED in case of well handled exceptions returning from server having jobresultcode as 530
Date Wed, 14 May 2014 13:25:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20659/#review42956
-----------------------------------------------------------


Commit 9106cfb4be7d157cc4574e4dcfeb61d3792cc673 in cloudstack's branch refs/heads/4.4-forward
from SrikanteswaraRao Talluri
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=9106cfb ]

Revert "CLOUDSTACK-5674: Fixed cloudstackConnection.py to return FAILED in case of well handled
exceptions returning from server having jobresultcode as 530"

This reverts commit aaa2f5932ba8f7d3ef08ad5176744811589176f5.


- ASF Subversion and Git Services


On May 12, 2014, 6:04 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20659/
> -----------------------------------------------------------
> 
> (Updated May 12, 2014, 6:04 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5674
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5674
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> In case of well handled exceptions returned from the server with proper error message,
the response was as it is returned. Instead, it should check the jobresultcode. If the jobresultcode
is 530, it means that exception is returned from server. In this case we should return FAILED.
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/cloudstackConnection.py 8044da7 
>   tools/marvin/marvin/codes.py ef49c0c 
> 
> Diff: https://reviews.apache.org/r/20659/diff/
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message