cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Amogh Vasekar" <amogh.vase...@citrix.com>
Subject Re: Review Request 21340: Disallow deleting / modifying system defined mappings
Date Mon, 12 May 2014 22:31:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21340/
-----------------------------------------------------------

(Updated May 12, 2014, 10:31 p.m.)


Review request for cloudstack and Nitin Mehta.


Changes
-------

Same modifications for guest OS


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6437
    https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6437


Repository: cloudstack-git


Description
-------

This patch disallows deleting / modifying system defined guest OS mappings


Diffs (updated)
-----

  api/src/org/apache/cloudstack/api/ApiConstants.java 70e1984420219f1f6c1638d161717464584b8460

  api/src/org/apache/cloudstack/api/response/GuestOSResponse.java 9737d6073adefbdd683243288aeda982917a8073

  api/src/org/apache/cloudstack/api/response/GuestOsMappingResponse.java a0f7d1d0edd3cd06575f7c26db4340f4c5fb6aaf

  engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDao.java 5b6e7198f0d28d105c051390daf3383d2447216b

  engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDaoImpl.java b06cdfad68291b1b660fa219f1b3e144f1c684ff

  server/src/com/cloud/api/ApiResponseHelper.java d8e26d8f8bf6a8a8916aacade1827435c61c8397

  server/src/com/cloud/server/ManagementServerImpl.java da252986011dc29df76098123a1d269ad418dcfb


Diff: https://reviews.apache.org/r/21340/diff/


Testing
-------

Local env
1. Create user defined mapping
2. Delete / modify user defined mapping. Should pass
3. Delete / modify system defined mapping. Should fail


Thanks,

Amogh Vasekar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message