cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF Subversion and Git Services" <asf...@urd.zones.apache.org>
Subject Re: Review Request 21156: CLOUDSTACK-6575: Deploy VM failed with NPE while using custom compute offering
Date Sun, 11 May 2014 09:30:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21156/#review42640
-----------------------------------------------------------


Commit 3943e0ba1c6fc343ac928980bb7309c7256b4e8e in cloudstack's branch refs/heads/4.4 from
Saksham Srivastava
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3943e0b ]

CLOUDSTACK-6575: Deploy VM failed with NPE while using custom compute offering


- ASF Subversion and Git Services


On May 7, 2014, 12:22 p.m., Saksham Srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21156/
> -----------------------------------------------------------
> 
> (Updated May 7, 2014, 12:22 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
> 
> 
> Bugs: CLOUDSTACK-6575
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6575
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Deploy VM failed with NPE while using custom compute offering:
> Steps to reproduce:
> 1. Install and configure Adv zone.
> 2. Create Compute offering with Custom option enabled.
> 3. Deploy VM using Default Cent OS template using Custom option enabled Compute offering.
> 
> Root Cause:
> In schema-410to420.sql ALTER TABLE `cloud`.`disk_offering` ADD COLUMN `customized_iops`
tinyint(1) unsigned COMMENT 'Should customized IOPS be displayed to the end user'; 
> 
> The default value of customized_iops is null and ServiceOfferingVO construtor calls the
super constructor in DiskOfferingVO passing null to boolean value, hence the NPE.
> 
> Fix: Change Boolean to boolean with appropriate conversions.
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/service/ServiceOfferingVO.java 3be0aaa 
> 
> Diff: https://reviews.apache.org/r/21156/diff/
> 
> 
> Testing
> -------
> 
> Deployed vm with customized_iops as null in disk_offering table.
> Deployed vm with customized_iops as not null in disk_offering table.
> Both the deployments pass.
> Build passes successfully.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message