cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "daan Hoogland" <daan.hoogl...@gmail.com>
Subject Re: Review Request 21200: Added Fix for CLOUDSTACK-6548
Date Fri, 09 May 2014 15:15:19 GMT


> On May 9, 2014, 3:07 p.m., daan Hoogland wrote:
> > 550493cec318a7ab2c0d5376183263ef2efba58e on 4.4 forward

00fcd9fb20009566b61a205c1eec28a65ea574db on master


- daan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21200/#review42571
-----------------------------------------------------------


On May 8, 2014, 10:48 a.m., Santhosh Edukulla wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21200/
> -----------------------------------------------------------
> 
> (Updated May 8, 2014, 10:48 a.m.)
> 
> 
> Review request for cloudstack and daan Hoogland.
> 
> 
> Bugs: CLOUDSTACK-6548
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6548
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> 1. Fixed a regression issue introduced for createPrivateNetwork
> 2. Mentioned test case "integration.smoke.test_privategw_acl.TestPrivateGwACL.test_privategw_acl",
post the fix
> was working fine. Below is the attached log.
> 3. Ran the checkstyle check
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/network/NetworkServiceImpl.java 05c2725 
>   server/src/com/cloud/network/vpc/VpcManagerImpl.java ad078fc 
> 
> Diff: https://reviews.apache.org/r/21200/diff/
> 
> 
> Testing
> -------
> 
> test_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName:
test_privategw_acl | Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 1 test in 127.279s
> 
> OK
> ~                                                                                   
                           
> ~                                                                                   
                           
> ~                                                                                   
                           
> ~         
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message