cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rajesh Battala" <rajesh.batt...@citrix.com>
Subject Re: Review Request 19270: Added service-instance delete command to Juniper Contrail Plugin and related fixes
Date Tue, 06 May 2014 06:32:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19270/#review42253
-----------------------------------------------------------



plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/DeleteServiceInstanceCmd.java
<https://reviews.apache.org/r/19270/#comment76044>

    As the service vm is specific to juniper-contrail, instead of using vm_destroy create
an specific event type. refer EVENT_INTERNAL_LB_VM_STOP/START


- Rajesh Battala


On May 3, 2014, 7:29 a.m., Sachchidanand Vaidya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19270/
> -----------------------------------------------------------
> 
> (Updated May 3, 2014, 7:29 a.m.)
> 
> 
> Review request for cloudstack and Rajesh Battala.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> This patch has following changes: 
>  - Added service-instance delete command to Juniper Contrail Plugin.
>  - Fixes to plugin code to handle instance-delete operation properly.
>  - Fix related to service-instance persistence and re-creation during Mgmt server reboot.
> 
> 
> Diffs
> -----
> 
>   client/tomcatconf/commands.properties.in 45debe4 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/DeleteServiceInstanceCmd.java
PRE-CREATION 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java
05723b0 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java
f81c0d0 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java
b9a3ed3 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java
e4ef26d 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java
f34eacc 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java
e79053c 
> 
> Diff: https://reviews.apache.org/r/19270/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed and additional testing done locally.
> 
> 
> Thanks,
> 
> Sachchidanand Vaidya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message