cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "daan Hoogland" <daan.hoogl...@gmail.com>
Subject Re: Review Request 20007: CLOUDSTACK-2697 - Populated the clusterId with actual value instead of Null in the alert message logs
Date Mon, 05 May 2014 17:10:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20007/#review42166
-----------------------------------------------------------

Ship it!


0babb92d62c08afc04aa0df1bbf053539a53c523

- daan Hoogland


On April 3, 2014, 4:49 p.m., Girish Chaudhari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20007/
> -----------------------------------------------------------
> 
> (Updated April 3, 2014, 4:49 p.m.)
> 
> 
> Review request for cloudstack and prashant mishra.
> 
> 
> Bugs: CLOUDSTACK-2697
>     https://issues.apache.org/jira/browse/CLOUDSTACK-2697
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-2697 - cluster id in alert message is null {alertType:: 1 // dataCenterId::
1 // podId:: 1 // clusterId:: null }
> 
> The Cluster ID is getting populated as null in the logs for the alert messages. In the
code base the ClusterId has been hardcoded as null for the log messages. I have modified to
code to provide the actual cluster ID. 
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/alert/AlertManagerImpl.java 2a343d5 
> 
> Diff: https://reviews.apache.org/r/20007/diff/
> 
> 
> Testing
> -------
> 
> Tested on the 4.3 platform. 
> 
> 
> Thanks,
> 
> Girish Chaudhari
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message