Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Received-SPF: pass (athena.apache.org: domain of Alena.Prokharchyk@citrix.com
 designates 66.165.176.63 as permitted sender)
From: Alena Prokharchyk <Alena.Prokharchyk@citrix.com>
To: Murali Reddy <Murali.Reddy@citrix.com>, "dev@cloudstack.apache.org"
	<dev@cloudstack.apache.org>
Subject: Network state machine
Thread-Topic: Network state machine
Thread-Index: AQHPWCnVL5i31+/SPki0k9r/2H5K+Q==
Date: Mon, 14 Apr 2014 21:38:12 +0000
Message-ID: <CF71A372.43F23%alena.prokharchyk@citrix.com>
Accept-Language: en-US
Content-Language: en-US
user-agent: Microsoft-MacOutlook/14.3.9.131030
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <1CC853CF97AA454F9BCF0334080CB79D@citrix.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Murali,

I have a question to you. In NetworkOrchestrator, implementNetwork code,
when we update the state for the network, why don=B9t we use state machine
for Shared networks, but instead update it directly in the DB?


if (isSharedNetworkWithServices(network)) {
                network.setState(Network.State.Implementing);
            } else {
                stateTransitTo(network, Event.ImplementNetwork);
            }


That doesn=B9t seem right to me as there should be no exception when it
comes to state update - the state machine should always be used once its
implemented for the object. If your code needs additional state
transitions for the Setup state, why can=B9t you add it?

Thanks,
Alena.