Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Received-SPF: pass (nike.apache.org: local policy includes SPF record at
 spf.trusted-forwarder.org)
MIME-Version: 1.0
Date: Tue, 29 Apr 2014 07:49:05 +0530
Message-ID: 
 <CAMWJVMusP=CwJnYE90zjpHamtmuocPbpTGexbuS0+JyTmUTGeA@mail.gmail.com>
Subject: [Reminder]:- Re: Review Request 20007: CLOUDSTACK-2697 - Populated
 the clusterId with actual value instead of Null in the alert message logs
From: Girish Chaudhari <girish.chaudhari@sungardas.com>
To: prashant mishra <prashantkumar.mishra@citrix.com>
Cc: cloudstack <dev@cloudstack.apache.org>,
	Girish Chaudhari <girish.chaudhari@sungard.com>
Content-Type: multipart/alternative; boundary=001a11c361dc5d547e04f8250eff

--001a11c361dc5d547e04f8250eff
Content-Type: text/plain; charset=ISO-8859-1

Can someone please have a look into this review request.

Thanks,
Girish

On Thu, Apr 3, 2014 at 10:19 PM, Girish Chaudhari <girish.chaudhari@sungard
.com> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20007/
>   Review request for cloudstack and prashant mishra.
> By Girish Chaudhari.
>  *Bugs: * CLOUDSTACK-2697<https://issues.apache.org/jira/browse/CLOUDSTACK-2697>
>  *Repository: * cloudstack-git
> Description
>
> CLOUDSTACK-2697 - cluster id in alert message is null {alertType:: 1 // dataCenterId:: 1 // podId:: 1 // clusterId:: null }
>
> The Cluster ID is getting populated as null in the logs for the alert messages. In the code base the ClusterId has been hardcoded as null for the log messages. I have modified to code to provide the actual cluster ID.
>
>   Testing
>
> Tested on the 4.3 platform.
>
>   Diffs
>
>    - server/src/com/cloud/alert/AlertManagerImpl.java (2a343d5)
>
> View Diff <https://reviews.apache.org/r/20007/diff/>
>

--001a11c361dc5d547e04f8250eff--