Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DA970117F7 for ; Wed, 16 Apr 2014 04:03:05 +0000 (UTC) Received: (qmail 85017 invoked by uid 500); 16 Apr 2014 04:03:05 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 84985 invoked by uid 500); 16 Apr 2014 04:03:04 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 84977 invoked by uid 99); 16 Apr 2014 04:03:04 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Apr 2014 04:03:04 +0000 X-ASF-Spam-Status: No, hits=-0.1 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_MED,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy includes SPF record at spf.trusted-forwarder.org) Received: from [74.125.149.247] (HELO na3sys009aog131.obsmtp.com) (74.125.149.247) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Apr 2014 04:02:59 +0000 Received: from mail-wg0-f45.google.com ([74.125.82.45]) (using TLSv1) by na3sys009aob131.postini.com ([74.125.148.12]) with SMTP ID DSNKU04A3V4MSqvt/Sj8jtlvaIbN1dgH8RRe@postini.com; Tue, 15 Apr 2014 21:02:39 PDT Received: by mail-wg0-f45.google.com with SMTP id l18so10285775wgh.4 for ; Tue, 15 Apr 2014 21:02:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc :content-type; bh=VJWJuJrmVxs9KdTCxrE0jJWD9T7g5GQQ8l2TueFTMDU=; b=MP6582/KygDGvJK77VC0i2/PYn3TaytyvUzLbRYd4U/yTEgcTk5wKWCtyH+cIoAalO nvMXCHI1o+fJfSEsT6ucTwYRnUajNIko42L6MxkqWsc78ZQAiJ6Zv+wEVXdKwCbA+ehD m1QD8WYx3JWWoY9CGTvFFo5j/G4dRO5SocRgBQH4pLyCRkMug1FEfzi01cllOqMje6E6 E9msXWyNqk/06frDLQ0XwNMYNxye9TlLMUohbmYnJh3EQBEcmQZnl09D4xkOngE2Tau+ 7l5EoD3r24KFvLOw90Fh5RWYvh4OqyG7FIV75TreljuiWIeHTndMkQroulLnqmUiGo/O 6L4w== X-Gm-Message-State: ALoCoQm4g0St42fiWC6MSUJRdKxvKmjUGVoGmPQWTe8XL4fEOMwmzsIkLiVDzHKR4rI2y1E78vXbitprMoB3Rz3k2PwjmEMpBpSeMND3lEsjj58RDez5hBFfd3aoneAFX2CHcHomWWiM X-Received: by 10.180.78.225 with SMTP id e1mr17336903wix.17.1397620956821; Tue, 15 Apr 2014 21:02:36 -0700 (PDT) X-Received: by 10.180.78.225 with SMTP id e1mr17336884wix.17.1397620956584; Tue, 15 Apr 2014 21:02:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.194.48.49 with HTTP; Tue, 15 Apr 2014 21:02:21 -0700 (PDT) From: Sonal Ojha Date: Wed, 16 Apr 2014 09:32:21 +0530 Message-ID: Subject: [REMINDER] Review Request 18677: CLOUDSTACK-3272 To: Murali Reddy Cc: Chiradeep Vittal , "dev@cloudstack.apache.org" Content-Type: multipart/related; boundary=f46d043c0864a6a5d004f720fcd8 X-Virus-Checked: Checked by ClamAV on apache.org --f46d043c0864a6a5d004f720fcd8 Content-Type: multipart/alternative; boundary=f46d043c0864a6a5ce04f720fcd7 --f46d043c0864a6a5ce04f720fcd7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Please take a look. ---------- Forwarded message ---------- From: Sonal Ojha Date: Tue, Apr 15, 2014 at 6:07 PM Subject: Re: Review Request 18677: CLOUDSTACK-3272 To: Murali Reddy , Chiradeep Vittal < chiradeepv@gmail.com> Cc: Sonal Ojha , cloudstack < dev@cloudstack.apache.org> This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ Review request for cloudstack, Chiradeep Vittal and Murali Reddy. By Sonal Ojha. *Updated April 15, 2014, 12:37 p.m.* Changes Removed the earlier not working patch files and added a new patch file (0001-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch) which works on master with commit 55f53e13e. I could successfully apply the latest patch attached on master and test the alert/action/resource/usage events published on rabbitmq message bus. Earlier patch didnt work as it was built on the older version and had some changes which werent required. Kindly take a look and revert back. *Bugs: * CLOUDSTACK-3272 *Repository: * cloudstack-git Description At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus. Testing Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events. Diffs - server/src/com/cloud/configuration/Config.java (2d55f46) - server/src/com/cloud/event/ActionEventUtils.java (00122de) - server/src/com/cloud/test/DatabaseConfig.java (9370218) View Diff File Attachments (updated) - Working patch for master (latest git commit 55f53e13e) --=20 *Thanks and Regards,* *Sonal Ojha =E2=96=AA Sr.Engineer - Product Development **=E2=96=AA **Sunga= rd Availability Services, India* 2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowledge Park, Pune - 411 014 = =E2=96=AA Office: 267-234-9014 =E2=96=AA Mobile: +91 9922412645 =E2=96=AA sonal.ojha@= sungardas.com =E2=96=AA www.sungardas. *in* *[image: Logo]* *[image: cid:image019.png@01CF48EC.6617C7F0]* *[image: cid:image020.png@01CF48EC.6617C7F0]* *[image: cid:image021.png@01CF48EC.6617C7F0]* *[image: cid:image022.png@01CF48EC.6617C7F0]* *[image: cid:image023.png@01CF48EC.6617C7F0]* *[image: cid:image024.png@01CF48EC.6617C7F0]* *CONFIDENTIALITY:* This e-mail (including any attachments) may contain confidential, proprietary and privileged information, and unauthorized disclosure or use is prohibited. If you received this e-mail in error, please notify the sender and delete this e-mail from your system. --f46d043c0864a6a5ce04f720fcd7 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Please take a look.

----= ------ Forwarded message ----------
From: = Sonal Ojha <sonal.ojha@sungard.com>
Date: Tue, Apr 15, 2014 at 6:07 PM
Subject: Re: Review Request 18677: CL= OUDSTACK-3272
To: Murali Reddy <muralimmreddy@gmail.com>, Chiradeep Vittal <chiradeepv@gmail.com>
Cc: Sonal Ojha <sonal.ojha@sun= gard.com>, cloudstack <dev@cloudstack.apache.org>


This is an automatically generated e-mail. To reply, visit: htt= ps://reviews.apache.org/r/18677/

Review request for cloudstack, Chiradeep Vittal and Murali Reddy.
By Sonal Ojha.

Updated April 15, 2014, 12:37 p.m.

Changes

Removed the earlier not working patch files and added a new patch file (00=
01-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch) which works =
on master with commit 55f53e13e. I could successfully apply the latest patc=
h attached on master and test the alert/action/resource/usage events publis=
hed on rabbitmq message bus. Earlier patch didnt work as it was built on th=
e older version and had some changes which werent required. Kindly take a l=
ook and revert back.
Repository: cloudstack-git

Description 
At present, there are multiple event types that are generated by CS, actio=
n events,usage events, resource state change events and alerts. Current pro=
blem is
all the events gets published on the event bus when event bus is enabled. I=
ntent is to introduce global setting config parameters to specify which cat=
egory of events to be published or not be published on the event bus.

Testing 

Successfully tested publishing / not publishing of various events based on=
 the global parameter publish.*.events.

Diffs

  • server/src/com/cloud/configuration/Config.java (2d55f46)
  • server/src/com/cloud/event/ActionEventUtils.java (00122de)
  • server/src/com/cloud/test/DatabaseConfig.java (9370218)

View Diff

File Attachment= s (updated)



--

Thanks and R= egards,

Sonal Ojha =E2=96=AA= Sr.Engineer - Product Development=C2=A0=E2=96=AA=C2=A0= Sungard Availability Services, India

2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowledge Park, Pune - 411 014= =C2=A0= =E2=96=AA Office: 267-234-9014=C2=A0=E2=96=AA=C2=A0Mobile: +91 992241= 2645 =E2=96=AA=C2=A0sonal.ojha@sungardas.com= =C2=A0=E2=96=AA=C2=A0= www.sungardas.in

3D"Logo"=
3D"cid:image019.png@01CF48EC.6617C7F0"=C2=A03D"cid:image020==C2=A03D"cid:image021.png@01CF48EC.6617C7F==C2=A03D"==C2= =A03D"cid:image023.pn==C2=A03D"cid:image024.png@01CF48EC.6617C7F0"
CONFIDENTIALITY:= =C2=A0 This e-mail (including any attachments) may contain confidential, pr= oprietary and privileged information, and unauthorized disclosure or use is= prohibited.=C2=A0=C2=A0If you received this e-mail in error, please notify= the sender and delete this e-mail from your system.

--f46d043c0864a6a5ce04f720fcd7-- --f46d043c0864a6a5d004f720fcd8--