Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6057711CFD for ; Mon, 28 Apr 2014 11:14:33 +0000 (UTC) Received: (qmail 33365 invoked by uid 500); 28 Apr 2014 11:14:32 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 32853 invoked by uid 500); 28 Apr 2014 11:14:31 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 32835 invoked by uid 99); 28 Apr 2014 11:14:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Apr 2014 11:14:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E4EE21D7191; Mon, 28 Apr 2014 11:14:24 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6040216852438849321==" MIME-Version: 1.0 Subject: Re: Review Request 20443: Integrate Deploy DB Into windows msi installer From: "Abhinandan Prateek" To: "Koushik Das" , "Abhinandan Prateek" , "Frank Zhang" Cc: "Damodar Reddy Talakanti" , "cloudstack" Date: Mon, 28 Apr 2014 11:14:24 -0000 Message-ID: <20140428111424.30656.87142@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Abhinandan Prateek" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/20443/ X-Sender: "Abhinandan Prateek" References: <20140424163537.21392.71298@reviews.apache.org> In-Reply-To: <20140424163537.21392.71298@reviews.apache.org> Reply-To: "Abhinandan Prateek" X-ReviewRequest-Repository: cloudstack-git --===============6040216852438849321== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20443/#review41587 ----------------------------------------------------------- Ship it! Ship It! - Abhinandan Prateek On April 24, 2014, 4:35 p.m., Damodar Reddy Talakanti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20443/ > ----------------------------------------------------------- > > (Updated April 24, 2014, 4:35 p.m.) > > > Review request for cloudstack, Abhinandan Prateek, Frank Zhang, and Koushik Das. > > > Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6271 > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6271 > > > Repository: cloudstack-git > > > Description > ------- > > Currently MSI Installer assumes that the back end DB is already created. But going further deploy db should be part of installation instead of assumption. of existence > > > Diffs > ----- > > Wix-cloudstack-maven-plugin/src/org/apache/cloudstack/wix/HeatMojo.java 9bfe382 > client/pom.xml aee2672 > scripts/installer/windows/Setup_Databases.wxs PRE-CREATION > scripts/installer/windows/WixInstallerDialog.wxs PRE-CREATION > scripts/installer/windows/acs.wxs 0e7dea7 > > Diff: https://reviews.apache.org/r/20443/diff/ > > > Testing > ------- > > Tested against Windows 2008 R2 server as changes are related to build process. > > > Thanks, > > Damodar Reddy Talakanti > > --===============6040216852438849321==--