Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D39B4112FF for ; Wed, 23 Apr 2014 12:40:11 +0000 (UTC) Received: (qmail 82860 invoked by uid 500); 23 Apr 2014 12:40:11 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 82629 invoked by uid 500); 23 Apr 2014 12:40:09 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 82618 invoked by uid 99); 23 Apr 2014 12:40:08 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Apr 2014 12:40:08 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 922731D5FE0; Wed, 23 Apr 2014 12:40:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5927422174983981363==" MIME-Version: 1.0 Subject: Re: Review Request 17586: AWSAPI: cloudstack api on POST requests (instead GET), ssl enabling fixed From: "daan Hoogland" To: "daan Hoogland" , "Sebastien Goasguen" Cc: "Dmitry Batkovich" , "cloudstack" Date: Wed, 23 Apr 2014 12:40:03 -0000 Message-ID: <20140423124003.29579.70888@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "daan Hoogland" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/17586/ X-Sender: "daan Hoogland" References: <20140422225002.23476.37311@reviews.apache.org> In-Reply-To: <20140422225002.23476.37311@reviews.apache.org> Reply-To: "daan Hoogland" X-ReviewRequest-Repository: cloudstack-git --===============5927422174983981363== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17586/#review41135 ----------------------------------------------------------- it seems awsapi/src/com/cloud/stack/CloudStackClientException.java is in this patch twice!?! Can you check the patch? awsapi/src/com/cloud/bridge/util/JsonElementUtil.java license header needed awsapi/src/com/cloud/stack/CloudStackClientException.java license header needed awsapi/test/com/cloud/gate/util/JsonElementUtilTestCase.java please apply the coding conventions (no tabs) awsapi/test/com/cloud/gate/util/JsonElementUtilTestCase.java please apply the coding conventions (no trailing spaces) - daan Hoogland On April 22, 2014, 10:50 p.m., Dmitry Batkovich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17586/ > ----------------------------------------------------------- > > (Updated April 22, 2014, 10:50 p.m.) > > > Review request for cloudstack, daan Hoogland and Sebastien Goasguen. > > > Repository: cloudstack-git > > > Description > ------- > > * CloudStackClient.java http request mechanism replaced from GET requests to POST for supporting EC2 requests larger than 2KB > * SSL enabling fixed in EC2Engine.java > > > Diffs > ----- > > awsapi/conf/ec2-service.properties.in 82f5ad8 > awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java cd20214 > awsapi/src/com/cloud/bridge/util/JsonAccessor.java 2a94dea > awsapi/src/com/cloud/bridge/util/JsonElementUtil.java PRE-CREATION > awsapi/src/com/cloud/bridge/util/JsonElementUtil.java 2d8afb5 > awsapi/src/com/cloud/stack/CloudStackApi.java b7a1210 > awsapi/src/com/cloud/stack/CloudStackClient.java 03eba96 > awsapi/src/com/cloud/stack/CloudStackClientException.java PRE-CREATION > awsapi/src/com/cloud/stack/CloudStackClientException.java ac1b3ef > awsapi/src/com/cloud/stack/CloudStackCommand.java 8d6aa68 > awsapi/src/com/cloud/stack/CloudStackQueryBuilder.java PRE-CREATION > awsapi/test/com/cloud/gate/util/CloudStackClientTestCase.java 826cb3a > awsapi/test/com/cloud/gate/util/JsonAccessorTestCase.java 8603e59 > awsapi/test/com/cloud/gate/util/JsonElementUtilTestCase.java PRE-CREATION > > Diff: https://reviews.apache.org/r/17586/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > cloudstack_api_post_and_ssl_fix.patch > https://reviews.apache.org/media/uploaded/files/2014/04/21/93dfe17d-2f7f-4413-80ba-76d33a3b5a47__cloudstack_api_post_and_ssl_fix.patch > > > Thanks, > > Dmitry Batkovich > > --===============5927422174983981363==--