Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DABF0111B2 for ; Tue, 15 Apr 2014 08:28:42 +0000 (UTC) Received: (qmail 36860 invoked by uid 500); 15 Apr 2014 08:28:41 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 36830 invoked by uid 500); 15 Apr 2014 08:28:40 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 36810 invoked by uid 99); 15 Apr 2014 08:28:39 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Apr 2014 08:28:38 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 17B8C1D3BFF; Tue, 15 Apr 2014 08:28:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0080706876079549111==" MIME-Version: 1.0 Subject: Re: Review Request 19917: Improvements on exception handlers (JIRA-6242) From: "daan Hoogland" To: "David Nalley" , "Laszlo Hornyak" , "Alex Huang" , "daan Hoogland" , "edison su" , "Prachi Damle" , "Mike Tutkowski" , "Venkata Siva Vijayendra Bhamidipati" , "Alena Prokharchyk" , "Chiradeep Vittal" Cc: "Ding Yuan" , "cloudstack" Date: Tue, 15 Apr 2014 08:28:33 -0000 Message-ID: <20140415082833.17634.19841@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "daan Hoogland" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/19917/ X-Sender: "daan Hoogland" References: <20140405031613.17825.8597@reviews.apache.org> In-Reply-To: <20140405031613.17825.8597@reviews.apache.org> Reply-To: "daan Hoogland" X-ReviewRequest-Repository: cloudstack-git --===============0080706876079549111== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19917/#review40362 ----------------------------------------------------------- Ship it! Ship It! - daan Hoogland On April 5, 2014, 3:16 a.m., Ding Yuan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19917/ > ----------------------------------------------------------- > > (Updated April 5, 2014, 3:16 a.m.) > > > Review request for cloudstack, Alena Prokharchyk, Alex Huang, Chiradeep Vittal, daan Hoogland, edison su, David Nalley, Laszlo Hornyak, Mike Tutkowski, Prachi Damle, and Venkata Siva Vijayendra Bhamidipati. > > > Repository: cloudstack-git > > > Description > ------- > > This is the patch for JIRA-6242. See https://issues.apache.org/jira/browse/CLOUDSTACK-6242 for more details. Thanks! > > > Diffs > ----- > > engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java 0d41bc1 > engine/orchestration/src/com/cloud/agent/manager/ClusteredAgentManagerImpl.java 01508a4 > engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 3e088db > engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/dao/EngineDataCenterDaoImpl.java 4b6818e > engine/schema/src/com/cloud/dc/dao/DataCenterDaoImpl.java ea5039f > engine/schema/src/com/cloud/host/dao/HostDaoImpl.java 426c90d > engine/schema/src/com/cloud/storage/dao/StoragePoolHostDaoImpl.java e42eaf4 > engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 34fdca5 > engine/schema/src/com/cloud/upgrade/dao/Upgrade2214to30.java 58dd916 > engine/schema/src/com/cloud/vm/dao/ConsoleProxyDaoImpl.java 5e9c2f0 > engine/schema/src/com/cloud/vm/dao/SecondaryStorageVmDaoImpl.java 1f382d6 > engine/storage/src/org/apache/cloudstack/storage/datastore/DataObjectManagerImpl.java 6ed1274 > framework/ipc/src/org/apache/cloudstack/framework/serializer/OnwireClassRegistry.java 83c8a42 > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java 0ad6dc4 > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServerConnectionPool.java b779085 > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServerStorageProcessor.java e512046 > plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/lifecycle/SolidFirePrimaryDataStoreLifeCycle.java af6a77a > server/src/com/cloud/resource/ResourceManagerImpl.java f9a59ba > server/src/com/cloud/server/ConfigurationServerImpl.java b8da4c8 > services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyThumbnailHandler.java 06f21d3 > utils/src/com/cloud/utils/net/NetUtils.java 6350986 > > Diff: https://reviews.apache.org/r/19917/diff/ > > > Testing > ------- > > > Thanks, > > Ding Yuan > > --===============0080706876079549111==--