Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CA4BC11018 for ; Tue, 8 Apr 2014 15:15:20 +0000 (UTC) Received: (qmail 76438 invoked by uid 500); 8 Apr 2014 15:15:20 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 75897 invoked by uid 500); 8 Apr 2014 15:15:19 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 75885 invoked by uid 99); 8 Apr 2014 15:15:18 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Apr 2014 15:15:18 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 13D751D5CB0; Tue, 8 Apr 2014 15:15:14 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3188871360008393476==" MIME-Version: 1.0 Subject: Review Request 20123: Fix for cloudstack-6328 to Prevent console proxy support scripts from spawning multiple java processes From: "Saurav Lahiri" To: "Rajesh Battala" , "Rajani Karuturi" Cc: "Saurav Lahiri" , "cloudstack" Date: Tue, 08 Apr 2014 15:15:13 -0000 Message-ID: <20140408151513.16004.67936@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Saurav Lahiri" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/20123/ X-Sender: "Saurav Lahiri" Reply-To: "Saurav Lahiri" X-ReviewRequest-Repository: cloudstack-git --===============3188871360008393476== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20123/ ----------------------------------------------------------- Review request for cloudstack, Rajani Karuturi and Rajesh Battala. Repository: cloudstack-git Description ------- With multiple java processes writing to the same logfile, each is not aware of the log4j's internal counter state, this needs to be prevented. So before starting new java process via the _run.sh , a check is made to ensure that there are no existing java processes running. This will prevent multiple java process writing to the same log file namely cloud.out. Diffs ----- systemvm/patches/debian/config/etc/init.d/cloud 83853bc systemvm/scripts/run.sh 146d96f systemvm/scripts/utils.sh PRE-CREATION Diff: https://reviews.apache.org/r/20123/diff/ Testing ------- Tested the changes with console proxy vm and secondary storage vm. They start and stop as expected. Thanks, Saurav Lahiri --===============3188871360008393476==--