Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F3E90100D8 for ; Tue, 1 Apr 2014 13:33:41 +0000 (UTC) Received: (qmail 36972 invoked by uid 500); 1 Apr 2014 13:33:40 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 36928 invoked by uid 500); 1 Apr 2014 13:33:39 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 36913 invoked by uid 99); 1 Apr 2014 13:33:38 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Apr 2014 13:33:38 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6B1861C011D; Tue, 1 Apr 2014 13:33:33 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4467877054500757985==" MIME-Version: 1.0 Subject: Re: Review Request 19119: CLOUDSTACK-5887: Resolved issue in test_base_image_updation.py From: "Santhosh Edukulla" To: "Santhosh Edukulla" , "SrikanteswaraRao Talluri" Cc: "Gaurav Aradhye" , "cloudstack" Date: Tue, 01 Apr 2014 13:33:33 -0000 Message-ID: <20140401133333.2770.32589@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Santhosh Edukulla" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/19119/ X-Sender: "Santhosh Edukulla" References: <20140312133823.22644.71592@reviews.apache.org> In-Reply-To: <20140312133823.22644.71592@reviews.apache.org> Reply-To: "Santhosh Edukulla" X-ReviewRequest-Repository: cloudstack-git --===============4467877054500757985== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19119/#review39152 ----------------------------------------------------------- test/integration/component/test_base_image_updation.py This will always fail if not through assert. Is that our intention to fail always? Also, we dont require an assert and fail in sequence. Use one of them. - Santhosh Edukulla On March 12, 2014, 1:38 p.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19119/ > ----------------------------------------------------------- > > (Updated March 12, 2014, 1:38 p.m.) > > > Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-5887 > https://issues.apache.org/jira/browse/CLOUDSTACK-5887 > > > Repository: cloudstack-git > > > Description > ------- > > The test case was failing while checking snapshot policies. In case the volume is deleted, snapshot policy won't list but if the volumes is not yet deleted, in that case snapshot policy list will be empty. > We should be checking both these conditions. > > > Diffs > ----- > > test/integration/component/test_base_image_updation.py af968cc > > Diff: https://reviews.apache.org/r/19119/diff/ > > > Testing > ------- > > Yes. > > Log: > Test deploy an instance with service offerings with IsVolatile set. ... SKIP: skip > Test rebooting instances created with isVolatile service offerings ... SKIP: skip > Test restoring a vm with different template than the one it was created with ... SKIP: skip > Create a VM using the Service offering IsVolatile enabled ... ok > > ---------------------------------------------------------------------- > Ran 4 tests in 1441.368s > > OK (SKIP=3) > > > Thanks, > > Gaurav Aradhye > > --===============4467877054500757985==--