cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Kelkar" <ashut...@clogeny.com>
Subject Re: Review Request 19399: CLOUDSTACK-6257: Resolving issue in template creation from user VM volume, added method to check the state of VM before template creation
Date Mon, 28 Apr 2014 10:41:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19399/
-----------------------------------------------------------

(Updated April 28, 2014, 10:41 a.m.)


Review request for cloudstack and Santhosh Edukulla.


Changes
-------

Rebased against latest Master. Including only library changes here. Will add test cases changes
later after testing. We can commit this change as it is independent.


Bugs: CLOUDSTACK-6257
    https://issues.apache.org/jira/browse/CLOUDSTACK-6257


Repository: cloudstack-git


Description
-------

As suggested, added getState method for VirtualMachine class, and it is called before template
creation. If VM fails to go into desired state, it returns failure.


Diffs (updated)
-----

  tools/marvin/marvin/codes.py 28e907c 
  tools/marvin/marvin/lib/base.py d753098 

Diff: https://reviews.apache.org/r/19399/diff/


Testing
-------

Yes.


Thanks,

Ashutosh Kelkar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message