cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rajani Karuturi" <rajanikarut...@gmail.com>
Subject Re: Review Request 20652: VR alerts for command failures during start and stop the router incase of failures
Date Mon, 28 Apr 2014 06:27:58 GMT


> On April 25, 2014, 10:58 a.m., Murali Reddy wrote:
> > Please use VirtualMachineGuru.finalizeStart as opportunity check the answers returned
by the VR start command. This would avoid VR specific logic spilling to orchestration layer.

Hi Murali, updated the patch with the suggested changes.


- Rajani


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20652/#review41459
-----------------------------------------------------------


On April 28, 2014, 6:27 a.m., Rajani Karuturi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20652/
> -----------------------------------------------------------
> 
> (Updated April 28, 2014, 6:27 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Jayapal Reddy, and Murali Reddy.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> added a new configuration router.start.strict to optionally stop the router in case of
command failures. Also added alerts for failures.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 466b861

> 
> Diff: https://reviews.apache.org/r/20652/diff/
> 
> 
> Testing
> -------
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Rajani Karuturi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message