cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murali Reddy" <muralimmre...@gmail.com>
Subject Re: Review Request 20652: VR alerts for command failures during start and option to stop the router incase of failures
Date Fri, 25 Apr 2014 10:58:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20652/#review41459
-----------------------------------------------------------


Please use VirtualMachineGuru.finalizeStart as opportunity check the answers returned by the
VR start command. This would avoid VR specific logic spilling to orchestration layer.

- Murali Reddy


On April 24, 2014, 5:45 a.m., Rajani Karuturi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20652/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 5:45 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Jayapal Reddy, and Murali Reddy.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> added a new configuration router.start.strict to optionally stop the router in case of
command failures. Also added alerts for failures.
> 
> 
> Diffs
> -----
> 
>   engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 6d18f86 
> 
> Diff: https://reviews.apache.org/r/20652/diff/
> 
> 
> Testing
> -------
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Rajani Karuturi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message