cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gabor Apati-Nagy" <gabor.apati-n...@citrix.com>
Subject Re: Review Request 20391: CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN)
Date Thu, 24 Apr 2014 21:47:38 GMT


> On April 22, 2014, 6:55 p.m., Brian Federle wrote:
> > Gabor, for the most part the UI is good. However, I did notice the 'provider' fields
on 'add VPC offering' are just simple text fields, instead of dropdowns -- is this intentional?
> 
> Gabor Apati-Nagy wrote:
>     Thanks for reviewing. Yes this is intentional. On that screen, we allow only VpcVirtualRouter
for all services except Connectivity that has 3 providers available.
> 
> Brian Federle wrote:
>     Thanks Gabor. The only modification to make then is to add the readonly="readonly"
attribute to the input box, assuming the user cannot change this value.

Good catch. But instead of making them readonly, I decided to change these back to dropdowns
(with one item in them)- so it is displayed like at all other places, so there is no chance
for confusion. Please see the modified patch. Thanks


- Gabor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20391/#review41038
-----------------------------------------------------------


On April 15, 2014, 11:41 p.m., Gabor Apati-Nagy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20391/
> -----------------------------------------------------------
> 
> (Updated April 15, 2014, 11:41 p.m.)
> 
> 
> Review request for cloudstack, Brian Federle and Jessica Wang.
> 
> 
> Bugs: CLOUDSTACK-6255
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6255
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC
and stretched L2 neworks (ui for SDN)
> (UI for SDN)
> 
> 
> Diffs
> -----
> 
>   client/WEB-INF/classes/resources/messages.properties bfa9600 
>   ui/dictionary.jsp f4d380c 
>   ui/scripts/configuration.js ba6bdce 
>   ui/scripts/docs.js df4bcf0 
>   ui/scripts/network.js 6494704 
>   ui/scripts/regions.js 66dae8c 
>   ui/scripts/ui/dialog.js 50e12f9 
>   ui/scripts/vpc.js 73d34df 
> 
> Diff: https://reviews.apache.org/r/20391/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gabor Apati-Nagy
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message