cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abhinandan Prateek" <aprat...@apache.org>
Subject Re: Review Request 20547: improved ldap logging.
Date Thu, 24 Apr 2014 09:22:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20547/#review41277
-----------------------------------------------------------

Ship it!


Ship It!

- Abhinandan Prateek


On April 22, 2014, 6:27 a.m., Rajani Karuturi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20547/
> -----------------------------------------------------------
> 
> (Updated April 22, 2014, 6:27 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Ian Duffy.
> 
> 
> Bugs: CLOUDSTACK-6471
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6471
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> added stacktrace in debug level incase of exceptions.
> 
> 
> Diffs
> -----
> 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapContextFactory.java
ceeed68 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
578ebce 
> 
> Diff: https://reviews.apache.org/r/20547/diff/
> 
> 
> Testing
> -------
> 
> manually tested the following cases incase of success or failure
> 
> 1a. configure ldap when server is not reachable
> 1b. configuration when server is reachable
> 2a. user authentication with wrong password
> 2b. user authentication with correct password
> 3a. no users displayed in list users due to ldap server going offline
> 3b. no users displayed in list users due to user object class configuration
> 
> 1a to 3a, stacktrace is logged in debug mode incase of failures.
> for 3b, no error will be logged as this is not an exception incase of ldap. cloudstack
will successfully bind but, will not see any users for the specified config.
> 
> 
> Thanks,
> 
> Rajani Karuturi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message