cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "daan Hoogland" <daan.hoogl...@gmail.com>
Subject Re: Review Request 19912: [CLOUDSTACK-6322] Fixed Contrail: Params validation is missing while launching a service instance thru cloudmonkey
Date Wed, 16 Apr 2014 12:59:45 GMT


> On April 15, 2014, 2:23 p.m., daan Hoogland wrote:
> > It would seem that this is a behavioral change that would break backwards compatibility,
is it? Right now empty service names are accepted. What is the consequence and why change
the behavior, can you shed light on the subject?
> > 
> > otherwise the change seems trivial enough and is applicable.
> 
> Sachchidanand Vaidya wrote:
>     Hi Daan,
>     
>      If user passes "null" string during instance creation then it's an issue since we
can't search service-instance with a null string as part of Fully Qualified Name lookup on
Contrail Controller. Hence user can't delete a service-instance with "null" string. Passing
empty string is functionally ok but we want to avoid both "null" and "empty" string since
 it's not a good idea from usability/debugability point of view.
>     
>     Thanks & Regards,
>     Sachin

ok, thanks. seems like a bug fix more then a behavioral change.


- daan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19912/#review40393
-----------------------------------------------------------


On April 2, 2014, 9:14 a.m., Sachchidanand Vaidya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19912/
> -----------------------------------------------------------
> 
> (Updated April 2, 2014, 9:14 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Don't allow service instance creation with empty or null service-instance "name"
> 
> 
> Diffs
> -----
> 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java
d2cb4de 
> 
> Diff: https://reviews.apache.org/r/19912/diff/
> 
> 
> Testing
> -------
> 
> Unit tested for null and empty "name" parameter.
> 
> 
> Thanks,
> 
> Sachchidanand Vaidya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message