cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohit Yadav" <bhais...@apache.org>
Subject Re: Review Request 20390: CLOUDSTACK-6202: Add signatureversion and expiring datetime to cloudmonkey, make it configurable
Date Wed, 16 Apr 2014 07:49:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20390/#review40514
-----------------------------------------------------------



cloudmonkey/config.py
<https://reviews.apache.org/r/20390/#comment73556>

    timeout and expires are misleading, can we make these config params more intuitive? Otherwise
LGTM



cloudmonkey/requester.py
<https://reviews.apache.org/r/20390/#comment73557>

    Won't this break backward compatibility? In case someone uses new cloudmonkey with old
CloudStack will this work? (Pardon my ignorance regarding the signature version changes and
API layer changes recently)


- Rohit Yadav


On April 15, 2014, 10:28 p.m., Yichi Lu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20390/
> -----------------------------------------------------------
> 
> (Updated April 15, 2014, 10:28 p.m.)
> 
> 
> Review request for cloudstack, Chiradeep Vittal and Rohit Yadav.
> 
> 
> Repository: cloudstack-cloudmonkey
> 
> 
> Description
> -------
> 
> use signature version 3 for cloudmonkey api calls, with 600 seconds expiration time as
default. The expiration time is configurable via .cloudmonkey/config
> 
> 
> Diffs
> -----
> 
>   cloudmonkey/cloudmonkey.py b465bec 
>   cloudmonkey/config.py 2f91608 
>   cloudmonkey/requester.py b06e1fc 
> 
> Diff: https://reviews.apache.org/r/20390/diff/
> 
> 
> Testing
> -------
> 
> for 600 seconds expiration time and CST:
> now:  2014-04-15T16:36:46+0000 , expires:  2014-04-15T21:46:46+0000
> 
> 
> Thanks,
> 
> Yichi Lu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message