cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yoshikazu Nojima" <m...@ynojima.net>
Subject Re: Review Request 20357: [CS-5907] [CS-6396] Fix for RBD (and potentially CLVM) volumes w/ KVM incorrectly identified as OVM volumes (not able to snapshot)
Date Wed, 16 Apr 2014 04:02:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20357/#review40494
-----------------------------------------------------------


It seems getHypervisorTypeFromFormat method is only called from VolumeJoinDaoImpl#newVolumeResponse.

It should be fixed, but does it affect snapshot feature?

- Yoshikazu Nojima


On April 16, 2014, 3:23 a.m., Tanner Danzey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20357/
> -----------------------------------------------------------
> 
> (Updated April 16, 2014, 3:23 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-5907 and CLOUDSTACK-6396
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5907
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6396
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fix for RBD (and potentially CLVM) volumes w/ KVM incorrectly identified as OVM volumes
(not able to snapshot)
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/api/ApiDBUtils.java 67e47f7 
> 
> Diff: https://reviews.apache.org/r/20357/diff/
> 
> 
> Testing
> -------
> 
> Applied on otherwise clean 4.4 branch and tested in a live testing environment with KVM
hypervisors and RBD primary storage pool that would otherwise identify as OVM. No errors and
no weird behavior. Just the expected result.
> 
> 
> Thanks,
> 
> Tanner Danzey
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message