cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "daan Hoogland" <daan.hoogl...@gmail.com>
Subject Re: Review Request 20357: [CS-5907] [CS-6396] Fix for RBD (and potentially CLVM) volumes w/ KVM incorrectly identified as OVM volumes (not able to snapshot)
Date Tue, 15 Apr 2014 14:52:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20357/#review40394
-----------------------------------------------------------



server/src/com/cloud/api/ApiDBUtils.java
<https://reviews.apache.org/r/20357/#comment73374>

    I don't fully understand the logic of querying .next() and then .previous()
    
    It seems like guessing or is there some hard restrained that makes this the way to determine
this is KVM.
    
    Is this really the place to decide on hypervisor type?


- daan Hoogland


On April 15, 2014, 3:43 a.m., Tanner Danzey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20357/
> -----------------------------------------------------------
> 
> (Updated April 15, 2014, 3:43 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-5907 and CLOUDSTACK-6396
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5907
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6396
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fix for RBD (and potentially CLVM) volumes w/ KVM incorrectly identified as OVM volumes
(not able to snapshot)
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/api/ApiDBUtils.java 67e47f7 
> 
> Diff: https://reviews.apache.org/r/20357/diff/
> 
> 
> Testing
> -------
> 
> Applied on otherwise clean 4.4 branch and tested in a live testing environment with KVM
hypervisors and RBD primary storage pool that would otherwise identify as OVM. No errors and
no weird behavior. Just the expected result.
> 
> 
> Thanks,
> 
> Tanner Danzey
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message