cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "daan Hoogland" <daan.hoogl...@gmail.com>
Subject Re: Review Request 20365: CLOUDSTACK-6411: some files are not loading in visual studio due to license header at top making them unparsable
Date Tue, 15 Apr 2014 13:46:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20365/#review40388
-----------------------------------------------------------



plugins/hypervisors/hyperv/DotNet/ServerResource/.nuget/NuGet.Config
<https://reviews.apache.org/r/20365/#comment73372>

    Did you check if it worked with the license header below the xml header?


- daan Hoogland


On April 15, 2014, 8:44 a.m., Anshul Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20365/
> -----------------------------------------------------------
> 
> (Updated April 15, 2014, 8:44 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
> 
> 
> Bugs: CLOUDSTACK-6411
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6411
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
>  some files are not loading in visual studio due to license header at top making them
unparsable. removed the license header and put them in exclude list of rat plugin
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/.nuget/NuGet.Config 5181cb8 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentSettings.settings
fb5b962 
>   pom.xml 6837717 
> 
> Diff: https://reviews.apache.org/r/20365/diff/
> 
> 
> Testing
> -------
> 
> verified with rat plugin that the license check is passed successfully
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message