cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Koushik Das" <koushik....@citrix.com>
Subject Re: Review Request 20250: Fixed errors with simulator VM snapshot delete and revert
Date Tue, 15 Apr 2014 10:36:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20250/#review40378
-----------------------------------------------------------

Ship it!


Ship It!

- Koushik Das


On April 11, 2014, 2:37 a.m., Chris Suich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20250/
> -----------------------------------------------------------
> 
> (Updated April 11, 2014, 2:37 a.m.)
> 
> 
> Review request for cloudstack and Alex Huang.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> When doing some testing with the simulator, I found that VM snapshot delte and revert
were failing with an error saying that a vm with the specified name didn't exist. It appears
that a '!=' should have been an '=='. After that, there was a NPE because the simulator manager
wasn't sending a volume TO list back.
> 
> This patch fixes those issues so that simulator VM snapshot delete and revert now works
as expected.
> 
> I just wanted to throw this up for review since the change that caused this error was
fairly recent. Alex - can you confirm whether this was just a typo of '!=' instead of '=='?
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/simulator/src/com/cloud/agent/manager/MockVmManagerImpl.java f487eb4

> 
> Diff: https://reviews.apache.org/r/20250/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chris Suich
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message