cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Santhosh Edukulla" <santhosh.eduku...@citrix.com>
Subject Re: Review Request 20123: Fix for cloudstack-6328 to Prevent console proxy support scripts from spawning multiple java processes
Date Mon, 14 Apr 2014 08:58:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20123/#review40251
-----------------------------------------------------------



systemvm/scripts/run.sh
<https://reviews.apache.org/r/20123/#comment73207>

    How do we achieve syncrhonization and avoid few race flows here? I mean by the time pid
value is retrieved at 30, and went to line 32, there could be a pid available genuinely for
process check we are doing? 
    
    As well, if run.sh is called multiple times at same time, the value will not be synchronous,
then there is no lock protection here?



systemvm/scripts/run.sh
<https://reviews.apache.org/r/20123/#comment73206>

    What to do in case of multiple processes running? 



systemvm/scripts/utils.sh
<https://reviews.apache.org/r/20123/#comment73204>

    Where is this variable used?



systemvm/scripts/utils.sh
<https://reviews.apache.org/r/20123/#comment73208>

    This is not lock protected and can be run and called multiple times, may lead to unwarranted
values.



systemvm/scripts/utils.sh
<https://reviews.apache.org/r/20123/#comment73205>

    Where is the variable CLOUD_COM_HOME defined?


- Santhosh Edukulla


On April 14, 2014, 7:15 a.m., Saurav Lahiri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20123/
> -----------------------------------------------------------
> 
> (Updated April 14, 2014, 7:15 a.m.)
> 
> 
> Review request for cloudstack, Jayapal Reddy, Rajani Karuturi, and Rajesh Battala.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> With multiple java processes writing to the same logfile, each is not aware of the log4j's
internal counter state, this needs to be prevented. So before starting new java process via
the _run.sh , a check is made to ensure that there are no existing java processes running.
This will prevent multiple java process writing to the same log file namely cloud.out. 
> 
> 
> Diffs
> -----
> 
>   systemvm/patches/debian/config/etc/init.d/cloud 83853bc 
>   systemvm/scripts/run.sh 146d96f 
>   systemvm/scripts/utils.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20123/diff/
> 
> 
> Testing
> -------
> 
> Tested the changes with console proxy vm and secondary storage vm. They start and stop
as expected.
> 
> 
> Thanks,
> 
> Saurav Lahiri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message