cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kishan Kavala" <Kishan.Kav...@citrix.com>
Subject Re: Review Request 20152: In com.cloud.utils.crypt.EncryptionSecretKeyChecker the key file paths are hard coded
Date Thu, 10 Apr 2014 06:24:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20152/#review39991
-----------------------------------------------------------

Ship it!


commit 1d0b14673da2b877112a4030c17496e26cf3f531
Please file a ticket to change key name cloudstack specific like.. cloudstack.key

- Kishan Kavala


On April 9, 2014, 6:01 p.m., Damodar Reddy Talakanti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20152/
> -----------------------------------------------------------
> 
> (Updated April 9, 2014, 6:01 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Kishan Kavala.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6354
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6354
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> In com.cloud.utils.crypt.EncryptionSecretKeyChecker the key file paths are hard coded
to "/etc/cloudstack/management/key" which will cause issue if key generation path gets changes
during installation time.
> 
> 
> Diffs
> -----
> 
>   utils/src/com/cloud/utils/crypt/EncryptionSecretKeyChecker.java 0e995c4 
>   utils/test/com/cloud/utils/crypto/EncryptionSecretKeyCheckerTest.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/20152/diff/
> 
> 
> Testing
> -------
> 
> Tested with enabling ecnryption.
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message