cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rajani Karuturi" <rajanikarut...@gmail.com>
Subject Re: Review Request 19584: CLOUDSTACK-6258: Disable systemvm cloud startup script from logging messages to /var/log/cloud/cloud.out
Date Mon, 07 Apr 2014 05:02:11 GMT


> On April 4, 2014, 6:01 a.m., Rajani Karuturi wrote:
> > systemvm/patches/debian/config/etc/init.d/cloud, line 36
> > <https://reviews.apache.org/r/19584/diff/2/?file=547785#file547785line36>
> >
> >     Can we consider $CLOUD_DEBUG not set as true ie) log to cloud.out when $CLOUD_DEBUG
is not set or $CLOUD_DEBUG is 1 ?
> >     
> >     redirect to /dev/null when $CLOUD_DEBUG is 0
> >     
> >     this way, it wont change the default behaviour of it. whoever doesnt want logging
can set the variable to 0
> 
> Saurav Lahiri wrote:
>     Since the earlier behaviour was causing the file system to fill up( which is a serious
issue) , I would think that changing that and preventing the init script to write to cloud.out,
should be useful. And if required logging can be turned on, any problems identified and turned
off.
> 
> Saurav Lahiri wrote:
>     So if there is a confusion here, the fix only prevents messages logged by the init
shell script, the java process will still continue to log messages via log4j and roll over
once it reaches maxSize. This has not changed.

agreed


- Rajani


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19584/#review39517
-----------------------------------------------------------


On April 3, 2014, 2:12 p.m., Saurav Lahiri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19584/
> -----------------------------------------------------------
> 
> (Updated April 3, 2014, 2:12 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> This will prevent the /etc/init.d/cloud script from logging messages to /var/log/cloud/cloud.out
if the CLOUD_DEBUG flag is not defined. If the flag is defined only then will messages be
logged. This is because the cloud.out file gets rolled over once max size is reached via the
log4j settings, since the script is not aware of the log4j settings it causes the log file
to exceed its max size and fill up the file system. 
> 
> 
> Diffs
> -----
> 
>   systemvm/patches/debian/config/etc/init.d/cloud 83853bc 
> 
> Diff: https://reviews.apache.org/r/19584/diff/
> 
> 
> Testing
> -------
> 
> The console proxy vm was started and console sessions tested. The secondary storage vm
was succesfully started.
> 
> 
> Thanks,
> 
> Saurav Lahiri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message