cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jayapal Reddy" <jayapalreddy.ur...@citrix.com>
Subject Re: Review Request 19916: Updated listLoadBalancerRuleInstances, removeFromLoadBalancerRule APIs for VM secondary ip addresses
Date Wed, 02 Apr 2014 13:06:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19916/
-----------------------------------------------------------

(Updated April 2, 2014, 1:06 p.m.)


Review request for cloudstack, Abhinandan Prateek, Chiradeep Vittal, and Murali Reddy.


Bugs: CLOUDSTACK-6327
    https://issues.apache.org/jira/browse/CLOUDSTACK-6327


Repository: cloudstack-git


Description
-------

Configuring load balancing rules for VM secondary ip address feature is in 4.4.

In this patch updated 'listLoadBalancerRuleInstances' API response to display the VM ip address.

Also updated the removeFromLoadBalancerRule to remove the specific vm and ip entry which assigned
to LB rule.


Diffs
-----

  api/src/com/cloud/network/lb/LoadBalancingRulesService.java 6643de6 
  api/src/org/apache/cloudstack/api/ApiConstants.java 1146cea 
  api/src/org/apache/cloudstack/api/command/admin/loadbalancer/ListLoadBalancerRuleInstancesCmdByAdmin.java
26202b9 
  api/src/org/apache/cloudstack/api/command/user/loadbalancer/ListLoadBalancerRuleInstancesCmd.java
2d458a7 
  api/src/org/apache/cloudstack/api/command/user/loadbalancer/RemoveFromLoadBalancerRuleCmd.java
8714d34 
  api/src/org/apache/cloudstack/api/response/LoadBalancerRuleVmMapResponse.java PRE-CREATION

  engine/schema/src/com/cloud/network/dao/LoadBalancerVMMapDao.java 51f45c2 
  engine/schema/src/com/cloud/network/dao/LoadBalancerVMMapDaoImpl.java bb24e04 
  server/src/com/cloud/network/as/AutoScaleManagerImpl.java 8fafcc9 
  server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java 4e6d6fd 

Diff: https://reviews.apache.org/r/19916/diff/


Testing
-------

Tested listLoadBalancerRuleInstances API to display vm and vm ip address details.
Tested removing only specific ip of the VM from the LB rule.


Thanks,

Jayapal Reddy


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message