Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Received-SPF: pass (athena.apache.org: domain of Alena.Prokharchyk@citrix.com
 designates 66.165.176.63 as permitted sender)
From: Alena Prokharchyk <Alena.Prokharchyk@citrix.com>
To: Daan Hoogland <daan.hoogland@gmail.com>
CC: "dev@cloudstack.apache.org" <dev@cloudstack.apache.org>, David Grizzanti
	<david.grizzanti@sungard.com>
Subject: Re: Review Request 17591: CLOUDSTACK-5872: Async response from
 addAccountToProject doesn't contain useful information
Thread-Topic: Review Request 17591: CLOUDSTACK-5872: Async response from
 addAccountToProject doesn't contain useful information
Thread-Index: AQHPHpQpc8Htq7uzvUiZFWVoRfFUIprP2KaAgAABWoCAAW/YgIAAGAyA
Date: Tue, 4 Mar 2014 17:31:12 +0000
Message-ID: <CF3B4D91.408F2%alena.prokharchyk@citrix.com>
References: <20140131145138.21455.26939@reviews.apache.org>
 <20140303100339.10089.81898@reviews.apache.org>
 <CF3A04D9.40784%alena.prokharchyk@citrix.com>
 <CAGQtxvYD30AXCWny2ynuZP+Cip7zz2mhOEbhUNztOuq5BO0Pow@mail.gmail.com>
In-Reply-To: 
 <CAGQtxvYD30AXCWny2ynuZP+Cip7zz2mhOEbhUNztOuq5BO0Pow@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
user-agent: Microsoft-MacOutlook/14.3.9.131030
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <E9198E2E4FBD1E4AA9353A2048E56596@citrix.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Daan, you can=B9t extend the response with more parameters as its a generic
SuccessResponse used by many Apis, and you can=B9t add anything a particula=
r
call specific to that.

I think we shouldn=B9t fix the bug at this point. You can always get the
additional information you need by executing corresponding list* call.

-Alena.

On 3/4/14, 12:05 AM, "Daan Hoogland" <daan.hoogland@gmail.com> wrote:

>H Alena,
>
>You are right. I was under the impression that response format was
>being extended.
>
>I saw you already reverted. If the response was extended with the
>extra value it would be alright, would it?
>
>On Mon, Mar 3, 2014 at 7:06 PM, Alena Prokharchyk
><Alena.Prokharchyk@citrix.com> wrote:
>> Daan, this fix break API compatibility! All the customers using these
>>API,
>> will end up with broken code on their side. As the response format is
>> changed. Can you please roll it back?
>>
>> Thanks,
>> Alena.
>>
>> On 3/3/14, 2:03 AM, "daan Hoogland" <daan.hoogland@gmail.com> wrote:
>>
>>>
>>>-----------------------------------------------------------
>>>This is an automatically generated e-mail. To reply, visit:
>>>https://reviews.apache.org/r/17591/#review35953
>>>-----------------------------------------------------------
>>>
>>>Ship it!
>>>
>>>
>>>ebcaec8632dbd92c071317f3190915244a287afb
>>>
>>>- daan Hoogland
>>>
>>>
>>>On Jan. 31, 2014, 2:51 p.m., David Grizzanti wrote:
>>>>
>>>> -----------------------------------------------------------
>>>> This is an automatically generated e-mail. To reply, visit:
>>>> https://reviews.apache.org/r/17591/
>>>> -----------------------------------------------------------
>>>>
>>>> (Updated Jan. 31, 2014, 2:51 p.m.)
>>>>
>>>>
>>>> Review request for cloudstack.
>>>>
>>>>
>>>> Bugs: CLOUDSTACK-5872
>>>>     https://issues.apache.org/jira/browse/CLOUDSTACK-5872
>>>>
>>>>
>>>> Repository: cloudstack-git
>>>>
>>>>
>>>> Description
>>>> -------
>>>>
>>>> CLOUDSTACK-5872: Async response from addAccountToProject doesn't
>>>>contain useful information
>>>>
>>>> Updated the following classes to return a project object after async
>>>>jobs complete:
>>>>  api/src/com/cloud/projects/ProjectService.java     |  6 ++--
>>>>  .../user/account/AddAccountToProjectCmd.java       |  7 +++--
>>>>  .../user/account/DeleteAccountFromProjectCmd.java  |  7 +++--
>>>>  .../user/project/UpdateProjectInvitationCmd.java   |  8 +++--
>>>>  server/src/com/cloud/projects/ProjectManager.java  |  2 +-
>>>>  .../src/com/cloud/projects/ProjectManagerImpl.java | 34
>>>>+++++++++++-----------
>>>>  .../com/cloud/projects/MockProjectManagerImpl.java | 16 +++++-----
>>>>
>>>> Previously these API commands only returned "success =3D> true" in the
>>>>aysnc job result.  Now it returns the project that a user was
>>>>added/deleted to.
>>>>
>>>>
>>>> Diffs
>>>> -----
>>>>
>>>>   api/src/com/cloud/projects/ProjectService.java dc882ef
>>>>
>>>>api/src/org/apache/cloudstack/api/command/user/account/AddAccountToProj
>>>>ec
>>>>tCmd.java 36df579
>>>>
>>>>api/src/org/apache/cloudstack/api/command/user/account/DeleteAccountFro
>>>>mP
>>>>rojectCmd.java f6aa36c
>>>>
>>>>api/src/org/apache/cloudstack/api/command/user/project/UpdateProjectInv
>>>>it
>>>>ationCmd.java dda7b54
>>>>   server/src/com/cloud/projects/ProjectManager.java f568146
>>>>   server/src/com/cloud/projects/ProjectManagerImpl.java 5a0ed1c
>>>>   server/test/com/cloud/projects/MockProjectManagerImpl.java dc377ff
>>>>
>>>> Diff: https://reviews.apache.org/r/17591/diff/
>>>>
>>>>
>>>> Testing
>>>> -------
>>>>
>>>> Testing done on master.
>>>>
>>>>
>>>> Thanks,
>>>>
>>>> David Grizzanti
>>>>
>>>>
>>>
>>
>
>
>
>--=20
>Daan