Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Received-SPF: pass (athena.apache.org: local policy includes SPF record at
 spf.trusted-forwarder.org)
MIME-Version: 1.0
In-Reply-To: 
 <CAJCRRwzLYKteCH=NGgO6xATo+UmaL58NVk3ce08VCGy6zsDqvQ@mail.gmail.com>
References: 
 <CAJCRRwx9-oJ6oMFQ34WoE734wo9No7JOvOCJVGKkcyDiF0Uy-A@mail.gmail.com>
	<CACOnxChQ4pyNBXSwiMpDisz2Y6QetqDKBbe00gJ8c+kjxOvsoQ@mail.gmail.com>
	<CAJCRRwzLYKteCH=NGgO6xATo+UmaL58NVk3ce08VCGy6zsDqvQ@mail.gmail.com>
Date: Mon, 10 Mar 2014 09:35:27 +0530
Message-ID: 
 <CAJCRRwwAsGXjaveE66Q920vmgUEzzxmT0uCc1Ta6rs9mt6+eKQ@mail.gmail.com>
Subject: Re: CLOUDSTACK-5583: vmopsSnapshot plug-in (XenServer) does not
 return an error when it should
From: Mandar Barve <mandar.barve@sungard.com>
To: Mike Tutkowski <mike.tutkowski@solidfire.com>
Cc: cloudstack <dev@cloudstack.apache.org>
Content-Type: multipart/alternative; boundary=047d7bf0c106b0c5be04f438b654

--047d7bf0c106b0c5be04f438b654
Content-Type: text/plain; charset=ISO-8859-1

Hi Mike,
     Did you get a chance to look at this?

Thanks,
Mandar


On Wed, Mar 5, 2014 at 10:12 AM, Mandar Barve <mandar.barve@sungard.com>wrote:

> I tested this with CS 4.3.
>
> Thanks,
> Mandar
>
>
> On Tue, Mar 4, 2014 at 9:09 PM, Mike Tutkowski <
> mike.tutkowski@solidfire.com> wrote:
>
>> Hi,
>>
>> Can you tell me what release you tested this with? I noticed the problem
>> while developing on CloudStack 4.3.
>>
>> Thanks!
>>
>>
>> On Tue, Mar 4, 2014 at 3:43 AM, Mandar Barve <mandar.barve@sungard.com>wrote:
>>
>>> Hi,
>>>         I tried to reproduce the issue but couldn't get this to fail for
>>> insufficient space. I then injected an exception trying to list files from
>>> a non existent path (added this code in the "try" block). This landed me
>>> into the exception handling code. It raised correct exception saying "file
>>> not found" which was captured in the management server vmops log file. It
>>> was not displayed by the GUI. GUI just reported Error (Are we looking for
>>> GUI displaying error code?). The plugin code returns "0" immediately after
>>> the line of code that raises exception but I think this applies only for
>>> successful execution of the plugin code that reverts the snapshot.
>>>
>>>        If any exception is raised (e.g. in the reported case here
>>> insufficient space) then the code should return appropriate error message
>>> to the caller as I found. In exception handling path return "0" wouldn't
>>> execute.
>>>
>>> I don't see any problem here. Let me know if I am missing anything.
>>>
>>> Thanks,
>>> Mandar
>>>
>>
>>
>>
>> --
>> *Mike Tutkowski*
>>  *Senior CloudStack Developer, SolidFire Inc.*
>> e: mike.tutkowski@solidfire.com
>> o: 303.746.7302
>> Advancing the way the world uses the cloud<http://solidfire.com/solution/overview/?video=play>
>> *(tm)*
>>
>
>

--047d7bf0c106b0c5be04f438b654--