Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8D48210AD5 for ; Thu, 6 Mar 2014 22:08:21 +0000 (UTC) Received: (qmail 11880 invoked by uid 500); 6 Mar 2014 22:07:23 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 11035 invoked by uid 500); 6 Mar 2014 22:06:57 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 10810 invoked by uid 99); 6 Mar 2014 22:06:51 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Mar 2014 22:06:51 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of alex.hitchins@shapeblue.com designates 213.199.154.82 as permitted sender) Received: from [213.199.154.82] (HELO emea01-db3-obe.outbound.protection.outlook.com) (213.199.154.82) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Mar 2014 22:06:44 +0000 Received: from DB3PR07MB028.eurprd07.prod.outlook.com (10.242.137.156) by DB3PR07MB140.eurprd07.prod.outlook.com (10.242.132.27) with Microsoft SMTP Server (TLS) id 15.0.893.10; Thu, 6 Mar 2014 22:06:21 +0000 Received: from DB3PR07MB028.eurprd07.prod.outlook.com ([169.254.1.83]) by DB3PR07MB028.eurprd07.prod.outlook.com ([169.254.1.83]) with mapi id 15.00.0888.003; Thu, 6 Mar 2014 22:06:21 +0000 From: Alex Hitchins To: Daan Hoogland , dev CC: Devdeep Singh Subject: RE: Review Request 18844: Amended review request (origin: https://reviews.apache.org/r/17531/) Thread-Topic: Review Request 18844: Amended review request (origin: https://reviews.apache.org/r/17531/) Thread-Index: AQHPOUyzWKDjFGpwuUG6VQWJQKAJo5rUU0UAgABKE/A= Date: Thu, 6 Mar 2014 22:06:21 +0000 Message-ID: <8a72fd999d67421fac2af1219ef703b7@DB3PR07MB028.eurprd07.prod.outlook.com> References: <20140306145935.2625.6322@reviews.apache.org> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [86.174.251.137] x-forefront-prvs: 0142F22657 x-forefront-antispam-report: SFV:NSPM;SFS:(10009001)(6009001)(428001)(199002)(189002)(377454003)(51704005)(13734003)(164054003)(24454002)(13464003)(65816001)(93516002)(95666003)(86362001)(74876001)(92566001)(85806002)(76482001)(2656002)(54356001)(54316002)(53806001)(87936001)(81542001)(80022001)(77096001)(74662001)(74502001)(95416001)(31966008)(47446002)(66066001)(80976001)(74366001)(87266001)(85306002)(56776001)(74316001)(83072002)(94316002)(94946001)(46102001)(74706001)(97336001)(63696002)(85852003)(69226001)(15395725003)(56816005)(81816001)(50986001)(4396001)(47736001)(49866001)(77982001)(90146001)(15975445006)(97186001)(79102001)(59766001)(19580395003)(33646001)(83322001)(19580405001)(76576001)(51856001)(93136001)(76786001)(76796001)(81686001)(47976001)(81342001)(24736002);DIR:OUT;SFP:1101;SCL:1;SRVR:DB3PR07MB140;H:DB3PR07MB028.eurprd07.prod.outlook.com;CLIP:86.174.251.137;FPR:CCAC406D.8BF25F2A.FDF59D6F.44ED71BD.203E0;PTR:InfoNoRecords;A:1;MX:1;LANG:en; received-spf: None (: shapeblue.com does not designate permitted sender hosts) Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: shapeblue.com X-Virus-Checked: Checked by ClamAV on apache.org Ah, sorry - I'll delete this one and add to the original. Regards Alex Hitchins D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969 alex.hitchins@shapeblue.com -----Original Message----- From: Daan Hoogland [mailto:daan.hoogland@gmail.com] Sent: 06 March 2014 17:39 To: dev; Alex Hitchins Cc: Devdeep Singh Subject: Re: Review Request 18844: Amended review request (origin: https://= reviews.apache.org/r/17531/) Alex, you don't have to create a new review request for this. If you upload= a new version of the patch we can see the diff online and decide more easi= ly that concerns were met and no new concerns where introduced. On Thu, Mar 6, 2014 at 3:59 PM, Alexander Hitchins wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18844/ > ----------------------------------------------------------- > > Review request for cloudstack and Devdeep Singh. > > > Bugs: cloudstack-5440 > https://issues.apache.org/jira/browse/cloudstack-5440 > > > Repository: cloudstack-git > > > Description > ------- > > Please see amended script to add new os types. 32 & 64 bit separated and = hard coded to specific Id numbers. > > > Diffs > ----- > > setup/db/db/schema-430to440.sql acc7e21 > > Diff: https://reviews.apache.org/r/18844/diff/ > > > Testing > ------- > > Ran SQL, changes applied with no errors. > > > Thanks, > > Alexander Hitchins > -- Daan Need Enterprise Grade Support for Apache CloudStack? Our CloudStack Infrastructure Support offers the best 24/7 SLA for CloudStack Environments. Apache CloudStack Bootcamp training courses **NEW!** CloudStack 4.2.1 training 18th-19th February 2014, Brazil. Classroom 17th-23rd March 2014, Region A. Instructor led, On-line 24th-28th March 2014, Region B. Instructor led, On-line 16th-20th June 2014, Region A. Instructor led, On-line 23rd-27th June 2014, Region B. Instructor led, On-line This email and any attachments to it may be confidential and are intended s= olely for the use of the individual to whom it is addressed. Any views or o= pinions expressed are solely those of the author and do not necessarily rep= resent those of Shape Blue Ltd or related companies. If you are not the int= ended recipient of this email, you must neither take any action based upon = its contents, nor copy or show it to anyone. Please contact the sender if y= ou believe you have received this email in error. Shape Blue Ltd is a compa= ny incorporated in England & Wales. ShapeBlue Services India LLP is a compa= ny incorporated in India and is operated under license from Shape Blue Ltd.= Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and= is operated under license from Shape Blue Ltd. ShapeBlue is a registered t= rademark.