Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EE5B110928 for ; Fri, 28 Mar 2014 06:51:43 +0000 (UTC) Received: (qmail 7922 invoked by uid 500); 28 Mar 2014 06:51:43 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 7515 invoked by uid 500); 28 Mar 2014 06:51:42 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 7501 invoked by uid 99); 28 Mar 2014 06:51:40 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Mar 2014 06:51:40 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 000831D4952; Fri, 28 Mar 2014 06:51:36 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6656928253872032701==" MIME-Version: 1.0 Subject: Review Request 19780: [Windows] Check dependencies are installed or not through registry instead of environment variables From: "Damodar Reddy Talakanti" To: "daan Hoogland" , "Abhinandan Prateek" Cc: "Damodar Reddy Talakanti" , "cloudstack" Date: Fri, 28 Mar 2014 06:51:36 -0000 Message-ID: <20140328065136.14602.46293@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Damodar Reddy Talakanti" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/19780/ X-Sender: "Damodar Reddy Talakanti" Reply-To: "Damodar Reddy Talakanti" X-ReviewRequest-Repository: cloudstack-git --===============6656928253872032701== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19780/ ----------------------------------------------------------- Review request for cloudstack, Abhinandan Prateek and daan Hoogland. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6291 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6291 Repository: cloudstack-git Description ------- Previously we were checking environment variables to decide the needed dependencies are installed or not. This will some extra effort to the admin to set them before start installation of ACS. So removed that dependency and checking through registry to verify the same. Diffs ----- scripts/installer/windows/acs.wxs 9456a5a Diff: https://reviews.apache.org/r/19780/diff/ Testing ------- Tested on windows 2008R2 instance. Tested for the following use cases 1. Java is not installed 2. tomcat is not installed 3. 7z is not installed. Thanks, Damodar Reddy Talakanti --===============6656928253872032701==--