Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 463FF1125F for ; Mon, 24 Mar 2014 15:17:56 +0000 (UTC) Received: (qmail 65144 invoked by uid 500); 24 Mar 2014 15:17:55 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 65113 invoked by uid 500); 24 Mar 2014 15:17:53 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 65091 invoked by uid 99); 24 Mar 2014 15:17:51 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Mar 2014 15:17:51 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 243821D57E2; Mon, 24 Mar 2014 15:17:48 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8694332255168715405==" MIME-Version: 1.0 Subject: Re: Review Request 17586: AWSAPI: cloudstack api on POST requests (instead GET), ssl enabling fixed From: "Sebastien Goasguen" To: "Sebastien Goasguen" Cc: "Dmitry Batkovich" , "cloudstack" Date: Mon, 24 Mar 2014 15:17:47 -0000 Message-ID: <20140324151747.25880.55656@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Sebastien Goasguen" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/17586/ X-Sender: "Sebastien Goasguen" References: <20140324150115.25880.77919@reviews.apache.org> In-Reply-To: <20140324150115.25880.77919@reviews.apache.org> Reply-To: "Sebastien Goasguen" X-ReviewRequest-Repository: cloudstack-git --===============8694332255168715405== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On March 24, 2014, 3:01 p.m., Sebastien Goasguen wrote: > > I applied it to master (future 4.5) > > > > d5333f4596460c7123b66ad5c19fc69442696ea2 > > > > and 4.4 branch. > > Please test these new branches from source as I did not have time to test it. > > > > thanks a lot for the patch Dmitry, can you add the apache license headers and remove the @author tags. if you do it today, I will apply asap to avoid breaking the license checker. thanks, I should have caught that. - Sebastien ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17586/#review38297 ----------------------------------------------------------- On March 24, 2014, 2:50 p.m., Dmitry Batkovich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17586/ > ----------------------------------------------------------- > > (Updated March 24, 2014, 2:50 p.m.) > > > Review request for cloudstack and Sebastien Goasguen. > > > Repository: cloudstack-git > > > Description > ------- > > * CloudStackClient.java http request mechanism replaced from GET requests to POST for supporting EC2 requests larger than 2KB > * SSL enabling fixed in EC2Engine.java > > > Diffs > ----- > > awsapi/src/com/cloud/bridge/util/JsonAccessor.java 2a94dea > awsapi/src/com/cloud/bridge/util/JsonElementUtil.java PRE-CREATION > awsapi/src/com/cloud/stack/CloudStackClientException.java PRE-CREATION > awsapi/src/com/cloud/stack/CloudStackCommand.java 8d6aa68 > awsapi/src/com/cloud/stack/CloudStackQueryBuilder.java PRE-CREATION > awsapi/test/com/cloud/gate/util/JsonAccessorTestCase.java 8603e59 > awsapi/test/com/cloud/gate/util/JsonElementUtilTestCase.java PRE-CREATION > > Diff: https://reviews.apache.org/r/17586/diff/ > > > Testing > ------- > > > Thanks, > > Dmitry Batkovich > > --===============8694332255168715405==--