Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============7437435085099588319=="
MIME-Version: 1.0
Subject: Re: Review Request 19460: Check for returned null,
 throw exception rather than continue.
From: "Alex Hitchins" <alex.hitchins@shapeblue.com>
To: "cloudstack" <dev@cloudstack.apache.org>,
 "Chris Suich" <chris.suich@netapp.com>,
 "Alex Hitchins" <alex.hitchins@shapeblue.com>
Date: Thu, 20 Mar 2014 14:42:24 -0000
Message-ID: <20140320144224.6335.898@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Alex Hitchins" <noreply@reviews.apache.org>
References: <20140320120059.27584.99872@reviews.apache.org>
In-Reply-To: <20140320120059.27584.99872@reviews.apache.org>
Reply-To: "Alex Hitchins" <alex.hitchins@shapeblue.com>

--===============7437435085099588319==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19460/
-----------------------------------------------------------

(Updated March 20, 2014, 2:42 p.m.)


Review request for cloudstack.


Changes
-------

Amended patch to throw exception inside takeSnapshot method.


Repository: cloudstack-git


Description
-------

https://issues.apache.org/jira/browse/CLOUDSTACK-5825

I've added a check for null returned. Previously it would return even though there were errors. If null is returned, the takeSnapshot raised and caught an exception. I check for null and if received throw a new exception rather than continue the flow.


Diffs (updated)
-----

  engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java 68e5a56 

Diff: https://reviews.apache.org/r/19460/diff/


Testing
-------

Compiled and deployed on a new test system, completed steps and snapshots created successfully. 

I could not re-create a snapshot error, however normal operation is as expected. It's better it throws an exception rather than continue to log it's successful when it's not.


Thanks,

Alex Hitchins


--===============7437435085099588319==--