Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E860D105A5 for ; Wed, 19 Mar 2014 20:13:15 +0000 (UTC) Received: (qmail 79651 invoked by uid 500); 19 Mar 2014 20:13:14 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 79611 invoked by uid 500); 19 Mar 2014 20:13:13 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 79595 invoked by uid 99); 19 Mar 2014 20:13:13 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Mar 2014 20:13:13 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C5FD11D54DC; Wed, 19 Mar 2014 20:13:10 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8566587022200404897==" MIME-Version: 1.0 Subject: Re: Review Request 12228: static resource compression From: "Laszlo Hornyak" To: "Prasanna Santhanam" , "Darren Shepherd" , "Brian Federle" Cc: "Laszlo Hornyak" , "daan Hoogland" , "cloudstack" Date: Wed, 19 Mar 2014 20:13:10 -0000 Message-ID: <20140319201310.6335.99364@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Laszlo Hornyak" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/12228/ X-Sender: "Laszlo Hornyak" References: <20140202170435.14570.67319@reviews.apache.org> In-Reply-To: <20140202170435.14570.67319@reviews.apache.org> Reply-To: "Laszlo Hornyak" X-ReviewRequest-Repository: cloudstack-git --===============8566587022200404897== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12228/ ----------------------------------------------------------- (Updated March 19, 2014, 8:13 p.m.) Review request for cloudstack, Brian Federle, Darren Shepherd, and Prasanna Santhanam. Changes ------- -updated to use plugin from central repo -fixed spaces/tabs -license header added Summary (updated) ----------------- static resource compression Repository: cloudstack-git Description ------- CloudStack at first use downloads some 3.5 MB of css and javascript to the client. With a weak internet connection, this might take a long time. With gzip compression content can be compressed to 850 KB. This version of the patch uses a custom plugin to compress static resources, so that no dynamic compression is needed at runtime. When the static resource servlet notices that there is gzipped version of the resource and the client accepts gzipped content, then it is going to send the gziped version, while still respects http caching. Diffs (updated) ----- client/WEB-INF/web.xml 1af38e1 client/pom.xml 615d244 server/src/com/cloud/servlet/StaticResourceServlet.java PRE-CREATION server/test/com/cloud/servlet/StaticResourceServletTest.java PRE-CREATION Diff: https://reviews.apache.org/r/12228/diff/ Testing (updated) ------- yes, tested with firefox and chrome Thanks, Laszlo Hornyak --===============8566587022200404897==--