Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============2653158134206618342=="
MIME-Version: 1.0
Subject: Re: Review Request 17736: CLOUDSTACK-5999: Virtual Router does not
 start if
 Guest VM is rebooted from CloudStack
From: "Saksham Srivastava" <saksham.srivastava@citrix.com>
To: "Murali Reddy" <muralimmreddy@gmail.com>,
 "John Burwell" <jburwell@basho.com>
Cc: "Saksham Srivastava" <saksham.srivastava@citrix.com>,
 "cloudstack" <dev@cloudstack.apache.org>
Date: Thu, 13 Mar 2014 07:31:45 -0000
Message-ID: <20140313073145.32376.24574@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Saksham Srivastava" <noreply@reviews.apache.org>
References: <20140313070209.32376.43970@reviews.apache.org>
In-Reply-To: <20140313070209.32376.43970@reviews.apache.org>
Reply-To: "Saksham Srivastava" <saksham.srivastava@citrix.com>

--===============2653158134206618342==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17736/
-----------------------------------------------------------

(Updated March 13, 2014, 7:31 a.m.)


Review request for cloudstack, John Burwell and Murali Reddy.


Bugs: CLOUDSTACK-5999
    https://issues.apache.org/jira/browse/CLOUDSTACK-5999


Repository: cloudstack-git


Description
-------

When a guest is rebooted from CloudStack, if the virtual router managing the guest network of that guest is down, CloudStack will not start the virtual router.
However the router is started in case the guest vm is stopped and then started.
To mantain similarity between the 2 process it is necessary to start the VR in case it is not running.
The fix will address the same.


Diffs
-----

  server/src/com/cloud/vm/UserVmManagerImpl.java be00aa8 

Diff: https://reviews.apache.org/r/17736/diff/


Testing
-------

Testing:
1) vm in a single guest network :
               vm Reboot : If the VR is stopped: VR is first started and then the VM reboots.
               vm Reboot : If the VR is running, VM reboots as it used to.
vm Stop/Start continue to work the same.

2)  vm having nics in multi networks :
               vm Reboot : If VR in any/all network is stopped: VRs are first started and then the VM reboots.
               vm Reboot : If the VRs are running, VM reboots as it used to.
vm Stop/Start continue to work the same.

3) vpc :
               Tested the above scenarios for vpc also, works fine.

Patch applies cleanly.
Build passes succesfully.
FindBug is passed.
Rebased against latest master.


Thanks,

Saksham Srivastava


--===============2653158134206618342==--